From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAF8FC4332F for ; Wed, 16 Nov 2022 21:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234117AbiKPVkR (ORCPT ); Wed, 16 Nov 2022 16:40:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234119AbiKPVkM (ORCPT ); Wed, 16 Nov 2022 16:40:12 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B453639F; Wed, 16 Nov 2022 13:40:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2DC38B81EBC; Wed, 16 Nov 2022 21:40:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5CD4C433D6; Wed, 16 Nov 2022 21:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668634807; bh=ARfrvyFLGorIZ3kzUAoR0AQIez47iYNNUSrsyVHjxOM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nGEtCwfsVmZWtjN6QaGOVnweV0CvMDiPR8DEGjg6SRFBztRwUG7KV0ZLjdky/IGaO 7cxAax5L/nwK16SsZq7pfzK0JNBkfKWGXCtwdjyxZ/FMFcxlcYcGvG3oZJDyQc7EU8 h4TzZtATG3MYXCSnlK81akfdj029Dbx0hLrRUzCgepxPiWG4s+Vj4SDKraYKGhb70U M6l8j3C1qN2TjdVYrUdp+43Jo1r+YNUIgAoh5yQGjbSLTKlewE4XEiErts03t1KIiL mHwKdJeIaD3yJKQIQwHXcguyHa8gjY94HGVBJHLDNv84BxU9b857P8OcaXBS5W/vuq Ro9MGrzl8DcoA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovQ8b-006Zq2-9F; Wed, 16 Nov 2022 21:40:05 +0000 Date: Wed, 16 Nov 2022 21:40:04 +0000 Message-ID: <865yfepoi3.wl-maz@kernel.org> From: Marc Zyngier To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek , Nick Desaulniers Subject: Re: [PATCH] kbuild: Restore .version auto-increment behaviour for Debian packages In-Reply-To: References: <20221115220453.3463096-1-maz@kernel.org> <867czvozhn.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: masahiroy@kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, michal.lkml@markovi.net, ndesaulniers@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Nov 2022 20:56:38 +0000, Masahiro Yamada wrote: > > On Wed, Nov 16, 2022 at 9:28 PM Marc Zyngier wrote: > > > > On Wed, 16 Nov 2022 06:09:31 +0000, > > Masahiro Yamada wrote: > > > > > > On Wed, Nov 16, 2022 at 7:05 AM Marc Zyngier wrote: > > > > > > > > Since 2df8220cc511 ("kbuild: build init/built-in.a just once"), > > > > generating Debian packages using 'make bindeb-pkg' results in > > > > packages that are stuck to the same .version, leading to unexpected > > > > behaviours (multiple packages with the same version). > > > > > > > > That's because the mkdebian script samples the build version > > > > before building the kernel, and forces the use of that version > > > > number for the actual build. > > > > > > > > Restore the previous behaviour by calling init/build-version > > > > instead of reading the .version file. This is likely to result > > > > in too many .version bumps, but this is what was happening before > > > > (although the bump was affecting builds made after the current one). > > > > > > > > > What do you mean by "too many .version bumps"? > > > > > > Every "make bindeb-pkg" increments the version by one. > > > > And isn't that a problem? We increase the build number pointlessly, > > even if there is *nothing* to change. > > > I think "make *-pkg" should increment the version every time. But that's not what the rpm package builder does. > > > The .version is incremented only when vmlinux is updated. > > When you change module code, only *.ko is relinked. > The .version stays because it is embedded in vmlinux. > > > Even if you build the kernel first, and .version has no change, > the package contents may have some changes. And again, isn't that an inconsistency? Anyway, enough idle arguing. What do want me to do about this bug? M. -- Without deviation from the norm, progress is not possible.