Re: [PATCH 03/10] drm/panthor: Replace the panthor_irq macro machinery by inline helpers

Boris Brezillon
2026-04-30T10:38:56Z

On Thu, 30 Apr 2026 10:40:32 +0100
Karunika Choo <karunika.choo@arm.com> wrote:

> > +
> > +static irqreturn_t panthor_job_irq_threaded_handler(int irq, void *data)
> > +{
> > + return panthor_irq_default_threaded_handler(data, panthor_job_irq_handler);
> > +}
> >
>
> Hello,
>
> Maybe we can consider embedding the slow_handler into struct panthor_irq?
> You can then always use a default threaded IRQ handler here and call
> pirq->slow_handler when needed.

The idea here was that the compiler can basically inline
panthor_irq_default_threaded_handler() and turn
panthor_job_irq_handler() into a direct call. If we make it a true
function pointer stored in panthor_irq level this optimization
can't happen.