Re: [PATCH 07/10] drm/panthor: Automate CSG IRQ processing at group unbind time

Boris Brezillon
2026-05-04T15:00:58Z

On Fri, 1 May 2026 14:53:22 +0100
Steven Price <steven.price@arm.com> wrote:

> > @@ -2970,8 +2963,6 @@ void panthor_sched_suspend(struct panthor_device *ptdev)
> >
> > if (flush_caches_failed)
> > csg_slot->group->state = PANTHOR_CS_GROUP_TERMINATED;
> > - else
> > - csg_slot_sync_update_locked(ptdev, csg_id);
>
> The justification for this change doesn't seem to be included in the
> commit message and looks suspicious.

Hm, right. I somehow confused csg_slot_sync_update_locked() and
sched_process_csg_irq_locked().

> Although AFAICT the events_lock
> wouldn't be held here so it could trigger a lockdep assert before this
> change...

Yeah, the guard(spinlock_irqsave)(&sched->events_lock); should have
been added to patch 4.