The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	Thomas Gleixner <tglx@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Mark EL2 virtual timer broken for Tegra194/234
Date: Thu, 23 Jul 2026 09:39:53 +0100	[thread overview]
Message-ID: <867bmmdrqe.wl-maz@kernel.org> (raw)
In-Reply-To: <20260722125651.148595-1-jonathanh@nvidia.com>

On Wed, 22 Jul 2026 13:56:51 +0100,
Jon Hunter <jonathanh@nvidia.com> wrote:
> 
> The following warning is being observed on Tegra194 and Tegra234
> platforms ...
> 
>  arch_timer: [Firmware Bug]: VHE-capable CPU without EL2 virtual timer
>   interrupt
> 
> Adding the missing EL2 virtual timer in device-tree for Tegra194 and
> Tegra234 is causing boot issues for both devices.
> 
> The Tegra194 device includes a GIC-400 which defines PPIs for sec-phys,
> phys, virt and hyp-phys timer interrupts (per the dt-binding
> arm,arch_timer.yaml) but there is no PPI hyp-virt (EL2 virtual) timer
> and hence this is not supported for this device.
> 
> The Tegra234 device does have a PPI for the EL2 virtual timer, but
> during CPU idle transitions into low-power states this timer is not
> preserved currently by firmware and hence causes boot issues when CPU
> idle is enabled.
> 
> Avoid the warning for Tegra194 and Tegra234 devices by marking the EL2
> virtual timer as broken.
> 
> Suggested-by: Marc Zyngier <maz@kernel.org>

This isn't what I suggested at [1]. The warnings are *required*,
because these systems are not compliant to the specification. Full
timer support was not optional last time I checked.

Thanks,

	M.

[1] https://lore.kernel.org/all/878q898ulx.wl-maz@kernel.org/

-- 
Without deviation from the norm, progress is not possible.

      parent reply	other threads:[~2026-07-23  8:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 12:56 [PATCH] clocksource/drivers/arm_arch_timer: Mark EL2 virtual timer broken for Tegra194/234 Jon Hunter
2026-07-22 13:42 ` Sudeep Holla
2026-07-23  8:39 ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=867bmmdrqe.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=daniel.lezcano@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox