From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B5245005 for ; Wed, 15 Jan 2025 14:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736950639; cv=none; b=jqTYEi/iMUkNbxtd2wrCZrMMyR7DXNXZO80T4FZnZKIFvqRw8y9MfULSexqpAugBHxPFqbbWvh11TCC+poUZgO9DlVBfjrjE28GIfSFTWCblbaTCF0DvsjPfflZvthfThb3cBuxPpmnFf1zKJXCV5ikHUwZsXKb0jY30eSJxAso= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736950639; c=relaxed/simple; bh=Ob0oswjFwEvQKzDjtvC3mgPatdmHimZJihQOAf60yPA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=pRGdq8yQP5aKj8ef1FvBXy6Abx9fqn3ihHTILID5JWQIp3cH+Jb7LwRJ/2V/gQ+woCmgom24pTaSJkwiUl1iZer8+0XTJNq8GQfQiHGHDPcxdeXTFCrke/KT9qR7e2566fe0drEihn2ydFhjVxygRJfbavMQses8wIrJxJlgvvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M3me4SOa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M3me4SOa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C84DC4CED1; Wed, 15 Jan 2025 14:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736950638; bh=Ob0oswjFwEvQKzDjtvC3mgPatdmHimZJihQOAf60yPA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M3me4SOaItmzlvbAxAEHYqJJixGrd0NQxn2pWFbYannP9qWBD2LBNCcvsd3GaZz9E ucZ7v0adQct3EBfMlPiL1q+zWW0z7uxmXP311QFCmpuLStgGbCOt9DUK0LhWQ3ULXB gbROXFBAfJ2S45cY/gY6SRuh3lPq0E8lous7Ec5bplHc5aWtNKv7SjJw2vGdOoZVK8 eqPrvNuafAUFjy3tizM5oVRxhB8XjBFSU8/G0JLE/EWHx+fAfrvm64VDmPPUBx/SED e4Rdvw331d0R/Wcm90Mv4edqKCuUbs09VY/hQcUJnIXDOQmM4nJZgWrkh7YwsQyOpp RQfDm+041LnZg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tY4Cq-00CVsm-4Z; Wed, 15 Jan 2025 14:17:16 +0000 Date: Wed, 15 Jan 2025 14:17:15 +0000 Message-ID: <867c6ww49g.wl-maz@kernel.org> From: Marc Zyngier To: James Clark Cc: linux-arm-kernel@lists.infradead.org, robh@kernel.org, broonie@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Oliver Upton , Anshuman Khandual , James Morse , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] arm64/sysreg: Enforce whole line match for closing blocks In-Reply-To: <20250115134259.1864060-3-james.clark@linaro.org> References: <20250115134259.1864060-1-james.clark@linaro.org> <20250115134259.1864060-3-james.clark@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: james.clark@linaro.org, linux-arm-kernel@lists.infradead.org, robh@kernel.org, broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, oliver.upton@linux.dev, anshuman.khandual@arm.com, james.morse@arm.com, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 15 Jan 2025 13:42:54 +0000, James Clark wrote: > > Match on the whole line to prevent matching on prefixes like "Endsysreg" > vs "EndsysregFields". This could potentially make the script go wrong > in weird ways so make it fall through to the fatal unhandled statement > catcher if it doesn't fully match the current block. > > Signed-off-by: James Clark > --- > arch/arm64/tools/gen-sysreg.awk | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/tools/gen-sysreg.awk b/arch/arm64/tools/gen-sysreg.awk > index 1a2afc9fdd42..7c7412adf90e 100755 > --- a/arch/arm64/tools/gen-sysreg.awk > +++ b/arch/arm64/tools/gen-sysreg.awk > @@ -127,7 +127,7 @@ END { > next > } > > -/^EndSysregFields/ && block_current() == "SysregFields" { > +/^EndSysregFields$/ && block_current() == "SysregFields" { The problem with this sort of things is that it will now fail with trailing spaces, which is both counter-intuitive and pretty hard to spot. Why don't you simply match the field number, like you do in patch 3? M. -- Without deviation from the norm, progress is not possible.