From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31B3715884F for ; Wed, 24 Jul 2024 14:36:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721831796; cv=none; b=Tu+9nKRhwVIGAkY1CxPiqQC647ADOeeDCtb2yPrPwsSA6Qjqo4EK8PQGCe4iU9h2p2gO4W3HCpP/0yhDSRnmtFg31/W8zrR67YMdPL9kaN1l5Q8KPMx4e5ke7PQ8pGJWPICJQ+4khJq+bgZuf7UhV3Of7JqoOAE3uOkZJffHNp0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721831796; c=relaxed/simple; bh=Vy2makQph1vBv9yaLQjTTAxrl6O97neZ2BLSX1zENkA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=JUgN7jse2AgB5n6VCfFXPUwaxGnPtOYpOLAWw8WM+7ylc9OULMB4RVAbiw5ptuQ+b3N9GKrwokpJLjg6gNYiJe4nwUX7zteYVxVf/YRHPMN1RFIfBlp+zxa4qMOPIWDdYu3HKZV9YkxFodLnBPAGlYYd7spXkbCU0/jm7+nv8D0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=O3g4xrjN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="O3g4xrjN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09370C32781; Wed, 24 Jul 2024 14:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721831796; bh=Vy2makQph1vBv9yaLQjTTAxrl6O97neZ2BLSX1zENkA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=O3g4xrjNY+45miLGNzlprZQaT2uJpeFAWeGvCN3Nf92J3eyO3+fa3LCiYwuJE0ChM VYKPE7dDxPUN5XZt67dUwpD1HDrWf+ZrJIGurt9p48QcKy6Y9wKMKcQq4hnrp423IJ 7/Wv1fD9tD24tJ1CcBHhpa5lilO1HzkxyB7FRwDokTEcPqzcdrp9cuvdK6564D4TzS GQkQKwC/zpA/uFChiY5PrmU6zccBHm37oe0yHo9/WmW8XVXdn0E5/nQVRnXmR57W/Y +xO4ipSxg9txfmLyiSmF2ih0FkPPeVP2lpUQKtJyoVj3kkZNPJf2tIs4tmUqVN5QxU U8pNhykjhEayw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sWd6X-00F2Fr-9D; Wed, 24 Jul 2024 15:36:33 +0100 Date: Wed, 24 Jul 2024 15:36:32 +0100 Message-ID: <867cda3lhr.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: Replace compared GIC version with ID_AA64PFR0_EL1_GIC_V4P1 In-Reply-To: <20240724054623.667595-1-anshuman.khandual@arm.com> References: <20240724054623.667595-1-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, catalin.marinas@arm.com, will@kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 24 Jul 2024 06:46:23 +0100, Anshuman Khandual wrote: > > Replace open encoding for GIC version code with ID_AA64PFR0_EL1_GIC_V4P1 in > gic_cpuif_has_vsgi(). Please fix the subject format to say "irqchip/gic-v4.1". > > Cc: Marc Zyngier > Cc: Thomas Gleixner > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > Applies after the following patch that fixes the given field in tools sysreg. > > https://lore.kernel.org/all/20240718215532.616447-1-rananta@google.com/ > > drivers/irqchip/irq-gic-v4.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c > index ca32ac19d284..58c28895f8c4 100644 > --- a/drivers/irqchip/irq-gic-v4.c > +++ b/drivers/irqchip/irq-gic-v4.c > @@ -97,7 +97,7 @@ bool gic_cpuif_has_vsgi(void) > > fld = cpuid_feature_extract_unsigned_field(reg, ID_AA64PFR0_EL1_GIC_SHIFT); > > - return fld >= 0x3; > + return fld >= ID_AA64PFR0_EL1_GIC_V4P1; > } > #else > bool gic_cpuif_has_vsgi(void) Please repost this *once* the dependent patch is actually merged, so that we don't have to think of the dependencies. With that: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.