From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4908947774; Wed, 10 Jan 2024 12:20:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JmIwlg4J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA3D3C43394; Wed, 10 Jan 2024 12:20:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704889233; bh=5t7pM8zZp6AKeeGGHlgcvmEhkhNLjDXqWLj2E37NZaQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JmIwlg4J8TzENN9/bveFVYUMVYadO/6DfyGrnoQyW40XH+Yz+io37DRGWFqY3qSXV vGbUXDRtbz7gJW1foTqagTXeNi1VNF3aaeRRPY6/d55/tLKPV2PTab380YP6bbTNRm Nzg2Ax8uy4EjB5CJgqkcrojBFEgBefLGJKdlVumvZqUH9qGADFBv/6cXbgOOtsoCoY 4JxY8VvYs1gfYdviqAMk/MIY1xOWDshdOO5MjB6iSo3dZvBgKDQKfAeBa1+8vl57qo DOTAMP8D7hHXMRcTPtXcGQ17JecozVTkRkndve5ExnvlhZEqGMcBppIpw0ex3gHh6V SqUhmTZl/Kwug== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rNXZP-00AVKC-91; Wed, 10 Jan 2024 12:20:31 +0000 Date: Wed, 10 Jan 2024 12:20:30 +0000 Message-ID: <867ckh9y7l.wl-maz@kernel.org> From: Marc Zyngier To: Ruidong Tian Cc: kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org Subject: Re: [PATCH] KVM: arm64: Add missing ERX*_EL1 registers In-Reply-To: <20240110075739.8291-1-tianruidong@linux.alibaba.com> References: <20240110075739.8291-1-tianruidong@linux.alibaba.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tianruidong@linux.alibaba.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 10 Jan 2024 07:57:39 +0000, Ruidong Tian wrote: > > Commit 464f2164da7e ("arm64: Add missing ERX*_EL1 encodings") add some > new RAS registers. Trap them to kvm. Well, they *are* already trapped by virtue of HCR_EL2.FIEN being 0. They are lacking a trap handler though. > > Signed-off-by: Ruidong Tian > --- > arch/arm64/kvm/sys_regs.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index 30253bd19917..76a9ba155d58 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -2389,8 +2389,13 @@ static const struct sys_reg_desc sys_reg_descs[] = { > { SYS_DESC(SYS_ERXCTLR_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXSTATUS_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXADDR_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXPFGF_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXPFGCTL_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXPFGCDN_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXMISC0_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXMISC1_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXMISC2_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXMISC3_EL1), trap_raz_wi }, > > MTE_REG(TFSR_EL1), > MTE_REG(TFSRE0_EL1), If my reading of the ARM ARM is correct, these registers only exist if FEAT_RASv1p1 is implemented. Which means that we shouldn't handle those as RAZ/WI unconditionally, but instead check for what we advertise to the guest and handle it accordingly. Thanks, M. -- Without deviation from the norm, progress is not possible.