From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09904C433FF for ; Tue, 13 Aug 2019 16:18:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1FAC20840 for ; Tue, 13 Aug 2019 16:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565713131; bh=tJJ+TaiCiYhD6k4pfUYXUVNglQJSMrwBnwLe6W0R8Hc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Gpfe1RSNOfciVRBgldXeSOPFwwqtORgETlRe2ZEsmKPzlJXacohfIYURJlw7Pd7Ri rqX4sVywB/iq/w/73UiKo3UtA257Qk8x9Tw2hchuKCDpd2ANS4X8VTHoRFLPP7FpUJ 9TambPdX7JdVEVXTW4zYHVLXPF/L9Pn5u6ZXLCQc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728122AbfHMQSv convert rfc822-to-8bit (ORCPT ); Tue, 13 Aug 2019 12:18:51 -0400 Received: from foss.arm.com ([217.140.110.172]:39762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727234AbfHMQSs (ORCPT ); Tue, 13 Aug 2019 12:18:48 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 25F26337; Tue, 13 Aug 2019 09:18:48 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06B243F706; Tue, 13 Aug 2019 09:18:44 -0700 (PDT) Date: Tue, 13 Aug 2019 17:18:36 +0100 Message-ID: <867e7hnin7.wl-maz@kernel.org> From: Marc Zyngier To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Peter De Schrijver , Thomas Gleixner , Jason Cooper , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] irqchip/tegra: Clean up coding style In-Reply-To: <4fbc5a90-e110-b020-15d3-c4bbe81b15cc@gmail.com> References: <20190811183044.13925-1-digetx@gmail.com> <20190811183044.13925-2-digetx@gmail.com> <86a7cdnmpx.wl-maz@kernel.org> <4fbc5a90-e110-b020-15d3-c4bbe81b15cc@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Organization: Approximate MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Aug 2019 16:40:27 +0100, Dmitry Osipenko wrote: > > 13.08.2019 17:50, Marc Zyngier пишет: > > On Sun, 11 Aug 2019 19:30:44 +0100, > > Dmitry Osipenko wrote: > >> > >> Make coding style to conform to the kernel's standard by fixing checkpatch > >> warnings about "line over 80 characters". > > > > The last time I used a VT100 was about 30 years ago. I still think > > this was one of the most brilliant piece of equipment DEC ever > > produced, but I replaced it at the time with a Wyse 50 that had a 132 > > column mode. But even then, I could make my XTerm as wide as I wanted, > > and things haven't regressed much since. > > > > More seriously, I don't consider the 80 column limit a hard one, and > > I'm pretty happy with code that spans more that 80 columns if that > > allows to read an expression without messing with the flow. > > Usually I have multiple source files opened side-by-side and the > view sizes are tuned for 80 chars, it messes at least my flow when > something goes over 80 chars. > > >> > >> Signed-off-by: Dmitry Osipenko > >> --- > >> drivers/irqchip/irq-tegra.c | 15 +++++---------- > >> 1 file changed, 5 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c > >> index 14dcacc2ad38..f829a5990dae 100644 > >> --- a/drivers/irqchip/irq-tegra.c > >> +++ b/drivers/irqchip/irq-tegra.c > >> @@ -74,7 +74,7 @@ static struct tegra_ictlr_info *lic; > >> > >> static inline void tegra_ictlr_write_mask(struct irq_data *d, unsigned long reg) > >> { > >> - void __iomem *base = (void __iomem __force *)d->chip_data; > >> + void __iomem *base = lic->base[d->hwirq / 32]; > > > > (1) This is an undocumented change > > In my opinion this is a very trivial change and then the end result > is absolutely the same, hence nothing to document here. Just read > the code, I'd say. And that is the very reason why I won't take any of your patches any time soon. M. -- Jazz is not dead, it just smells funny.