Re: [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

Keith Packard
2011-11-17T15:17:47Z

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

On Wed, 16 Nov 2011 18:14:55 +0100, Takashi Iwai <tiwai@suse.de> wrote:

> While refactoring of backlight control code in commit [a95735569:
> drm/i915: Refactor panel backlight controls], the handling of the bit
> 0 of duty-cycle was gone except for pineview. This resulted in invalid
> register values for old chips like 915GM. When the bit 0 is set, the
> backlight is turned off suddenly.

I'm looking at the mentioned patch and I don't see how that managed to
correctly handle bit 0; is this the patch that managed to break this?

--
keith.packard@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]