Re: mthca and LinuxBIOS

Greg KH
2005-08-05T22:02:37Z

On Fri, Aug 05, 2005 at 01:38:37PM -0700, Linus Torvalds wrote:
>
> Hmm.. This looks half-way sane, but too ugly for words.
>
> I'd much rather see that when we detect a 64-bit resource, we always mark
> the next resource as being reserved some way, and then we just make
> pci_update_resource() ignore such reserved resources.
>
> The
>
> if((resno & 1)==1) {
> /* check if previous reg is 64 mem */
> ..
>
> stuff is really too ugly.

Yeah, that's not nice.

But what's the real problem we are trying to fix here? I seem to have
missed that in the email thread somehow.

> Greg? Ivan?

Ivan's the pci resource guru, any thoughts as to how to do this in a
nicer way?

thanks,

greg k-h