public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yinghai.lu@amd.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>, "Andi Kleen" <ak@muc.de>
Cc: "linux kernel mailing list" <linux-kernel@vger.kernel.org>,
	yhlu.kernel@gmail.com
Subject: [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq
Date: Sat, 14 Oct 2006 02:01:57 -0700	[thread overview]
Message-ID: <86802c440610140201h5edd9ceay454cc192583a69c1@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

using irq_domain[irq] to get cpu_mask for send_IPI_mask

Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>

diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index 44b55f8..6a07bce 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
 static int ioapic_retrigger_irq(unsigned int irq)
 {
        cpumask_t mask;
-       unsigned vector;
+       int vector;

        vector = irq_vector[irq];
-       cpus_clear(mask);
-       cpu_set(vector >> 8, mask);
+       mask = irq_domain[irq];

-       send_IPI_mask(mask, vector & 0xff);
+       send_IPI_mask(mask, vector);

        return 1;
 }

[-- Attachment #2: io_apic_irq_trigger.diff --]
[-- Type: text/x-patch, Size: 537 bytes --]

diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index 44b55f8..6a07bce 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
 static int ioapic_retrigger_irq(unsigned int irq)
 {
 	cpumask_t mask;
-	unsigned vector;
+	int vector;
 
 	vector = irq_vector[irq];
-	cpus_clear(mask);
-	cpu_set(vector >> 8, mask);
+	mask = irq_domain[irq];
 
-	send_IPI_mask(mask, vector & 0xff);
+	send_IPI_mask(mask, vector);
 
 	return 1;
 }

             reply	other threads:[~2006-10-14  9:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-14  9:01 Yinghai Lu [this message]
2006-10-14 10:06 ` [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq Eric W. Biederman
2006-10-17 17:03 ` Eric W. Biederman
  -- strict thread matches above, loose matches on Subject: below --
2006-10-17 17:28 Lu, Yinghai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440610140201h5edd9ceay454cc192583a69c1@mail.gmail.com \
    --to=yinghai.lu@amd.com \
    --cc=ak@muc.de \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox