From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1758681AbYDJReA@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758681AbYDJReA (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Apr 2008 13:34:00 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756724AbYDJRdx
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 10 Apr 2008 13:33:53 -0400
Received: from wx-out-0506.google.com ([66.249.82.239]:5551 "EHLO
	wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756670AbYDJRdw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Apr 2008 13:33:52 -0400
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=SXMNSbwyBW7q3uAMhWCW3qjcQUcbjC/KR3f7Kymitx1PjPOGRNHOPFLqRUM7Lof+APt6tPg5+BlSRTFbN5IOvIcC00sFJyH74j3ftgm4ZfPxpM5P+XhZYiNH91wOjFU5WYUqAFMb6oq1CmJXutIy73UZGVHMEEufzpUhFHwj4UA=
Message-ID: <86802c440804101033p6e914cb4oacaeb6eca823d1cd@mail.gmail.com>
Date: Thu, 10 Apr 2008 10:33:50 -0700
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: npiggin@suse.de, "Andrew Morton" <akpm@linux-foundation.org>,
       "Andi Kleen" <andi@firstfloor.org>
Subject: Re: [patch 10/17] mm: fix bootmem alignment
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, pj@sgi.com,
       kniht@linux.vnet.ibm.com
In-Reply-To: <20080410171101.395469000@nick.local0.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080410170232.015351000@nick.local0.net>
	 <20080410171101.395469000@nick.local0.net>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 10, 2008 at 10:02 AM,  <npiggin@suse.de> wrote:
> Without this fix bootmem can return unaligned addresses when the start of a
>  node is not aligned to the align value. Needed for reliably allocating
>  gigabyte pages.
>
>  I removed the offset variable because all tests should align themself correctly
>  now. Slight drawback might be that the bootmem allocator will spend
>  some more time skipping bits in the bitmap initially, but that shouldn't
>  be a big issue.
>


this patch from Andi was obsoleted by the one in -mm


The patch titled
    mm: offset align in alloc_bootmem
has been added to the -mm tree.  Its filename is
    mm-offset-align-in-alloc_bootmem.patch

------------------------------------------------------
Subject: mm: offset align in alloc_bootmem
From: Yinghai Lu <yhlu.kernel.send@gmail.com>

Need offset alignment when node_boot_start's alignment is less than align
required

Use local node_boot_start to match align.  so don't add extra opteration in
search loop.

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Andi Kleen <ak@suse.de>
Cc: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Christoph Lameter <clameter@sgi.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>