Re: [PATCH] x86_64: simplify the memtest parameter setting

Frans Pop
2008-04-19T01:57:22Z

Yinghai Lu wrote:
> -config MEMTEST_BOOTPARAM
> - bool "Memtest boot parameter"
> +config MEMTEST
> + bool "Memtest"
> depends on X86_64
> default y

With this patch, this default no longer makes any sense.

> help
> This option adds a kernel parameter 'memtest', which allows memtest
> - to be disabled at boot. If this option is selected, memtest
> - functionality can be disabled with memtest=0 on the kernel
> - command line. The purpose of this option is to allow a single
> - kernel image to be distributed with memtest built in, but not
> - necessarily enabled.
> -
> + to be set.
> + memtest=0, mean disabled; -- default
> + memtest=1, mean do 1 test pattern;
> + ...
> + memtest=4, mean do 4 test patterns.

s/mean/means/
s/; -- default/ (default)/ although that does not really make sense either

Maybe some explanation of what a "test pattern" is would be useful.

> If you are unsure how to answer this question, answer Y.

Also makes no sense anymore.

Cheers,
FJP