From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757557AbYD3DBS (ORCPT ); Tue, 29 Apr 2008 23:01:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753596AbYD3DBA (ORCPT ); Tue, 29 Apr 2008 23:01:00 -0400 Received: from qb-out-0506.google.com ([72.14.204.237]:29234 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751246AbYD3DA6 (ORCPT ); Tue, 29 Apr 2008 23:00:58 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=YGmUV4i8wKh++kaFDNHvIX8ARgLqhVSSa3Jm3Vk8wjb9E8WspzVVJwbgzIrgJIzWyLsW+K00UL1aNOF24K3/Aw7/RVRPtxmTGQiKNM87NrVj/97bS4DbE5hwdF0ZxXVLXA4PFMYdSnN+vviWE+VmfCGB1FmYMC+juN+qvEWHjMk= Message-ID: <86802c440804292000j1b559bc2y8281fa1608d8e4af@mail.gmail.com> Date: Tue, 29 Apr 2008 20:00:56 -0700 From: "Yinghai Lu" To: "Gabriel C" Subject: Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7 Cc: "Andrew Morton" , "Ingo Molnar" , "H. Peter Anvin" , "Thomas Gleixner" , "Mika Fischer" , "linux-kernel@vger.kernel.org" In-Reply-To: <4817C52A.8000000@googlemail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_11125_4975222.1209524456841" References: <200804272337.40130.yhlu.kernel@gmail.com> <86802c440804290356l678d3a0cxedcbe21a1f7642d1@mail.gmail.com> <48170BDB.9000801@googlemail.com> <86802c440804291011g1cdd2c81h962f066dd7980282@mail.gmail.com> <48178434.90701@googlemail.com> <86802c440804291449y50f178a6x4e200c26840493a@mail.gmail.com> <4817B5B0.5090606@googlemail.com> <4817B811.9070707@googlemail.com> <86802c440804291738p401e339djda18d24bce324795@mail.gmail.com> <4817C52A.8000000@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ------=_Part_11125_4975222.1209524456841 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline On Tue, Apr 29, 2008 at 6:02 PM, Gabriel C wrote: > > Yinghai Lu wrote: > > On Tue, Apr 29, 2008 at 5:06 PM, Gabriel C wrote: > >> Gabriel C wrote: > >> > Yinghai Lu wrote: > >> >> On Tue, Apr 29, 2008 at 1:25 PM, Gabriel C wrote: > >> >>> Yinghai Lu wrote: > >> >>> > On Tue, Apr 29, 2008 at 4:51 AM, Gabriel C wrote: > >> >>> >> Yinghai Lu wrote: > >> >>> >> > On Tue, Apr 29, 2008 at 3:30 AM, Yinghai Lu wrote: > >> >>> >> >> On Tue, Apr 29, 2008 at 2:47 AM, Gabriel C wrote: > >> >>> >> >> > Yinghai Lu wrote: > >> >>> >> >> > > some BIOS like to use continus MTRR layout, and may X driver can not add > >> >>> >> >> > > WB entries for graphical cards when 4g or more RAM installed. > >> >>> >> >> > > > >> >>> >> >> > > the patch will change MTRR to discrete. > >> >>> >> >> > > > >> >>> >> >> > > mtrr_chunk_size= could be used to have smaller continuous block to hold holes. > >> >>> >> >> > > default is 256m, could be set according to size of graphics card memory. > >> >>> >> >> > > > >> >>> >> >> > > v2: fix -1 for UC checking > >> >>> >> >> > > v3: default to disable, and need use enable_mtrr_cleanup to enable this feature > >> >>> >> >> > > skip the var state change warning. > >> >>> >> >> > > remove next_basek in range_to_mtrr() > >> >>> >> >> > > v4: correct warning mask. > >> >>> >> >> > > v5: CONFIG_MTRR_SANITIZER > >> >>> >> >> > > v6: fix 1g, 2g, 512 aligment with extra hole > >> >>> >> >> > > v7: gran_sizek to prevent running out of MTRRs. > >> >>> >> >> > > > >> >>> >> >> > > >> >>> >> >> > With this version ( and patch http://lkml.org/lkml/2008/4/29/97 ) applyed on latest linus git tree > >> >>> >> >> > the box OOPS'es early. > >> >>> >> >> > > >> >>> >> >> > Sorry I don't have time right now to write down the part of the OOPS I can see on monitor , I can try to find > >> >>> >> >> > some time later. > >> >>> >> >> > > >> >>> >> >> > In any way OOPS'es on __free_one_page+0x191/0x21e > >> >>> >> >> > >> >>> >> >> thanks. found one problem with hole_basek ... > >> >>> >> >> > >> >>> >> >> will send you v8, and hope it will be last version. > >> >>> >> > > >> >>> >> > please try v8, it should get rid of the 8m entry. it need patch > >> >>> >> > http://lkml.org/lkml/2008/4/29/97 too. > >> >>> >> > >> >>> >> Box does boot with v8 but now I get that warning you fixed in v2 again =): > >> >>> >> > >> >>> >> .... > >> >>> >> [ 0.000000] Linux version 2.6.25-06058-ga01e035-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #805 SMP PREEMPT Tue Apr 29 13:04:49 CEST 2008 > >> >>> >> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 > >> >>> >> [ 0.000000] BIOS-provided physical RAM map: > >> >>> >> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > >> >>> >> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > >> >>> >> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > >> >>> >> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > >> >>> >> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> >>> >> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> >>> >> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> >>> >> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > >> >>> >> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > >> >>> >> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > >> >>> >> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > >> >>> >> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > >> >>> >> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > >> >>> >> [ 0.000000] max_pfn_mapped = 1228800 > >> >>> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > >> >>> >> [ 0.000000] After WB checking > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > >> >>> >> [ 0.000000] After UC checking > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> >>> >> [ 0.000000] After sorting > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> >> [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > >> >>> >> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > >> >>> >> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > >> >>> >> [ 0.000000] range: 00000000c0000000 - 00000000d0000000 > >> >>> >> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB > >> >>> >> [ 0.000000] hole: 00000000cc000000 - 00000000d0000000 > >> >>> >> [ 0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC > >> >>> >> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > >> >>> >> [ 0.000000] range0: 0000000100000000 - 0000000120000000 > >> >>> >> [ 0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB > >> >>> >> [ 0.000000] range: 0000000120000000 - 0000000130000000 > >> >>> >> [ 0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB > >> >>> >> [ 0.000000] hole: 000000012c000000 - 0000000130000000 > >> >>> >> [ 0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC > >> >>> >> [ 0.000000] DONE variable MTRRs > >> >>> >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > >> >>> >> [ 0.000000] After WB checking > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000 > >> >>> >> [ 0.000000] After UC checking > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> >> [ 0.000000] After sorting > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > >> >>> > > >> >>> > so > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> >>> >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> > ===> > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> >>> >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> > > >> >>> > please try > >> >>> > >> >>> Now I have 2 warnings > >> >>> > >> >>> > >> >>> > mtrr_chunk_size=512m mtrr_gran_size=128m > >> >>> > >> >>> ... > >> >>> > >> >>> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 mtrr_chunk_size=512m mtrr_gran_size=128m 3 > >> >>> > >> >>> > >> >>> [ 0.000000] BIOS-provided physical RAM map: > >> >>> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > >> >>> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > >> >>> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > >> >>> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > >> >>> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> >>> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> >>> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> >>> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > >> >>> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > >> >>> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > >> >>> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > >> >>> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > >> >>> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > >> >>> [ 0.000000] max_pfn_mapped = 1228800 > >> >>> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > >> >>> [ 0.000000] After WB checking > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > >> >>> [ 0.000000] After UC checking > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> >>> [ 0.000000] After sorting > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> >>> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> >>> [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > >> >>> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > >> >>> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > >> >>> [ 0.000000] range: 00000000c0000000 - 00000000c8000000 > >> >>> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB > >> >>> > >> >>> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > >> >>> [ 0.000000] range0: 0000000100000000 - 0000000120000000 > >> >>> [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB > >> >>> [ 0.000000] range: 0000000120000000 - 0000000128000000 > >> >>> [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB > >> >>> > >> >>> [ 0.000000] DONE variable MTRRs > >> >>> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > >> >>> [ 0.000000] After WB checking > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> >>> > >> >>> [ 0.000000] After UC checking > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> >>> [ 0.000000] After sorting > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> >>> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> >>> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM. > >> >>> [ 0.000000] ------------[ cut here ]------------ > >> >>> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1206 mtrr_trim_uncached_memory+0x25b/0x35a() > >> >>> > >> >>> [ 0.000000] Modules linked in: > >> >>> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805 > >> >>> [ 0.000000] > >> >>> [ 0.000000] Call Trace: > >> >>> [ 0.000000] [] warn_on_slowpath+0x51/0x78 > >> >>> [ 0.000000] [] x86_get_mtrr_mem_range+0x241/0x25c > >> >>> [ 0.000000] [] update_memory_range+0x95/0xb7 > >> >>> [ 0.000000] [] mtrr_trim_uncached_memory+0x25b/0x35a > >> >>> > >> >>> [ 0.000000] [] setup_arch+0x280/0x4a2 > >> >>> [ 0.000000] [] start_kernel+0x6e/0x308 > >> >>> [ 0.000000] [] x86_64_start_kernel+0x241/0x24a > >> >>> [ 0.000000] > >> >>> [ 0.000000] ---[ end trace ca143223eefdc828 ]--- > >> >>> [ 0.000000] update e820 for mtrr -- end_pfn > >> >>> [ 0.000000] modified physical RAM map: > >> >>> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > >> >>> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > >> >>> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > >> >>> [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable) > >> >>> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> >>> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> >>> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> >>> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > >> >>> [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved) > >> >>> [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable) > >> >>> [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved) > >> >>> > >> >>> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > >> >>> > >> >>> [ 0.000000] ------------[ cut here ]------------ > >> >>> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x30c/0x35a() > >> >>> [ 0.000000] Modules linked in: > >> >>> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805 > >> >>> [ 0.000000] > >> >>> [ 0.000000] Call Trace: > >> >>> [ 0.000000] [] warn_on_slowpath+0x51/0x78 > >> >>> [ 0.000000] [] x86_get_mtrr_mem_range+0x241/0x25c > >> >>> [ 0.000000] [] update_memory_range+0x95/0xb7 > >> >>> [ 0.000000] [] mtrr_trim_uncached_memory+0x30c/0x35a > >> >>> [ 0.000000] [] setup_arch+0x280/0x4a2 > >> >>> [ 0.000000] [] start_kernel+0x6e/0x308 > >> >>> [ 0.000000] [] x86_64_start_kernel+0x241/0x24a > >> >>> [ 0.000000] > >> >>> [ 0.000000] ---[ end trace ca143223eefdc828 ]--- > >> >>> [ 0.000000] update e820 for mtrr -- holes > >> >>> [ 0.000000] modified physical RAM map: > >> >>> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > >> >>> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > >> >>> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > >> >>> [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable) > >> >>> [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved) > >> >>> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> >>> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> >>> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> >>> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > >> >>> [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved) > >> >>> > >> >>> [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used > >> >>> [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used > >> >> please try attached trim_holes_fix.patch..., it will fix the trim hole problem. > >> > > >> > Tested but warning is still there. I try to boot with mtrr_chunk_size / mtrr_gran_size and see what I get. > >> > > >> > ... > >> > > >> > [ 0.000000] Linux version 2.6.25-06589-gc65a350-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #808 SMP PREEMPT Wed Apr 30 01:37:38 CEST 2008 > >> > [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 > >> > [ 0.000000] BIOS-provided physical RAM map: > >> > [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > >> > [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > >> > [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > >> > [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > >> > [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> > [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> > [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> > [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > >> > [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > >> > [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > >> > [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > >> > [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > >> > [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > >> > [ 0.000000] max_pfn_mapped = 1228800 > >> > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > >> > [ 0.000000] After WB checking > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > >> > [ 0.000000] After UC checking > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> > [ 0.000000] After sorting > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> > [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > >> > [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > >> > [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > >> > [ 0.000000] range: 00000000c0000000 - 00000000d0000000 > >> > [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB > >> > [ 0.000000] hole: 00000000cc000000 - 00000000d0000000 > >> > [ 0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC > >> > [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > >> > [ 0.000000] range0: 0000000100000000 - 0000000120000000 > >> > [ 0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB > >> > [ 0.000000] range: 0000000120000000 - 0000000130000000 > >> > [ 0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB > >> > [ 0.000000] hole: 000000012c000000 - 0000000130000000 > >> > [ 0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC > >> > [ 0.000000] DONE variable MTRRs > >> > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > >> > [ 0.000000] After WB checking > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000 > >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000 > >> > [ 0.000000] After UC checking > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> > [ 0.000000] After sorting > >> > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > >> > [ 0.000000] ------------[ cut here ]------------ > >> > [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x313/0x361() > >> > [ 0.000000] Modules linked in: > >> > [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06589-gc65a350-dirty #808 > >> > [ 0.000000] > >> > [ 0.000000] Call Trace: > >> > [ 0.000000] [] warn_on_slowpath+0x51/0x8c > >> > [ 0.000000] [] x86_get_mtrr_mem_range+0x241/0x25c > >> > [ 0.000000] [] update_memory_range+0x95/0xb7 > >> > [ 0.000000] [] mtrr_trim_uncached_memory+0x313/0x361 > >> > [ 0.000000] [] setup_arch+0x280/0x4a6 > >> > [ 0.000000] [] start_kernel+0x6e/0x30d > >> > [ 0.000000] [] x86_64_start_kernel+0x241/0x24a > >> > [ 0.000000] > >> > [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]--- > >> > [ 0.000000] update e820 for mtrr -- holes > >> > [ 0.000000] modified physical RAM map: > >> > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > >> > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > >> > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > >> > [ 0.000000] modified: 0000000000100000 - 00000000cc000000 (usable) > >> > [ 0.000000] modified: 00000000cc000000 - 00000000cf550000 (reserved) > >> > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > >> > [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved) > >> > [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used > >> > [ 0.000000] Entering add_active_range(0, 256, 835584) 3 entries of 256 used > >> > [ 0.000000] max_pfn_mapped = 1228800 > >> > [ 0.000000] init_memory_mapping > >> > > >> > ... > >> > > >> > >> with mtrr_chunk_size=256m mtrr_gran_size=128m I'm getting : > >> > >> ... > >> > >> > >> > >> [ 0.000000] BIOS-provided physical RAM map: > >> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > >> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > >> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > >> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > >> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > >> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > >> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > >> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > >> [ 0.000000] max_pfn_mapped = 1228800 > >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > >> [ 0.000000] After WB checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > >> [ 0.000000] After UC checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> [ 0.000000] After sorting > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > >> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > >> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > >> [ 0.000000] range: 00000000c0000000 - 00000000c8000000 > >> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB > >> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > >> [ 0.000000] range0: 0000000100000000 - 0000000120000000 > >> [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB > >> [ 0.000000] range: 0000000120000000 - 0000000128000000 > >> [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB > >> [ 0.000000] DONE variable MTRRs > >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > >> [ 0.000000] After WB checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> [ 0.000000] After UC checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> [ 0.000000] After sorting > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM. > >> [ 0.000000] ------------[ cut here ]------------ > >> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1206 mtrr_trim_uncached_memory+0x25b/0x361() > >> > >> [ 0.000000] Modules linked in: > >> [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06589-gc65a350-dirty #808 > >> [ 0.000000] > >> [ 0.000000] Call Trace: > >> [ 0.000000] [] warn_on_slowpath+0x51/0x8c > >> [ 0.000000] [] x86_get_mtrr_mem_range+0x241/0x25c > >> [ 0.000000] [] update_memory_range+0x95/0xb7 > >> [ 0.000000] [] mtrr_trim_uncached_memory+0x25b/0x361 > >> > >> [ 0.000000] [] setup_arch+0x280/0x4a6 > >> [ 0.000000] [] start_kernel+0x6e/0x30d > >> [ 0.000000] [] x86_64_start_kernel+0x241/0x24a > >> [ 0.000000] > >> [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]--- > >> > >> [ 0.000000] update e820 for mtrr -- end_pfn > >> [ 0.000000] modified physical RAM map: > >> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > >> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > >> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > >> [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable) > >> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > >> [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved) > >> [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable) > >> [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved) > >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > >> [ 0.000000] ------------[ cut here ]------------ > >> > >> [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x313/0x361() > >> [ 0.000000] Modules linked in: > >> [ 0.000000] Pid: 0, comm: swapper Tainted: G W 2.6.25-06589-gc65a350-dirty #808 > >> > >> [ 0.000000] > >> [ 0.000000] Call Trace: > >> [ 0.000000] [] warn_on_slowpath+0x51/0x8c > >> [ 0.000000] [] x86_get_mtrr_mem_range+0x241/0x25c > >> [ 0.000000] [] update_memory_range+0x95/0xb7 > >> [ 0.000000] [] mtrr_trim_uncached_memory+0x313/0x361 > >> [ 0.000000] [] setup_arch+0x280/0x4a6 > >> [ 0.000000] [] start_kernel+0x6e/0x30d > >> [ 0.000000] [] x86_64_start_kernel+0x241/0x24a > >> [ 0.000000] > >> [ 0.000000] ---[ end trace 4eaa2a86a8e2da22 ]--- > >> [ 0.000000] update e820 for mtrr -- holes > >> [ 0.000000] modified physical RAM map: > >> [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > >> [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > >> [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > >> > >> [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable) > >> [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved) > >> [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > >> [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved) > >> [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used > >> [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used > >> > > please check attached debug patch... > > Here the output : > > ... > > [ 0.000000] Linux version 2.6.25-06598-g33ae0cd-dirty (crazy@thor) (gcc version 4.3.0 (Frugalware Linux) ) #814 SMP PREEMPT Wed Apr 30 02:47:52 CEST 2008 > [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 mtrr_chunk_size=256m mtrr_gran_size=128m > > > [ 0.000000] BIOS-provided physical RAM map: > [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > [ 0.000000] max_pfn_mapped = 1228800 > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > [ 0.000000] After WB checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > [ 0.000000] After UC checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > [ 0.000000] After sorting > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > [ 0.000000] range: 00000000c0000000 - 00000000c8000000 > [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB > [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > [ 0.000000] range0: 0000000100000000 - 0000000120000000 > [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB > [ 0.000000] range: 0000000120000000 - 0000000128000000 > [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB > [ 0.000000] DONE variable MTRRs > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > [ 0.000000] After WB checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > [ 0.000000] After UC checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > [ 0.000000] After sorting > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > [ 0.000000] trimm e820 for MTRR MAP (UC): 0000000000128000 - 000000000012c000 > > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM. > > [ 0.000000] update e820 for mtrr -- end_pfn > [ 0.000000] modified physical RAM map: > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable) > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved) > [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable) > [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved) > [ 0.000000] trimm e820 for MTRR MAP (UC): 00000000000c8000 - 0000000000100000 > > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > > [ 0.000000] update e820 for mtrr -- holes > [ 0.000000] modified physical RAM map: > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable) > [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved) > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved) > [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used > [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used > > [ 0.000000] max_pfn_mapped = 1228800 > [ 0.000000] init_memory_mapping > > ... > > ( this kernel is still not build with your second cleanup patch will do so in next run ) > > Also let me know if you want me to boot with any other mtrr_chunk_size / mtrr_gran_size values. > i can not find problem with the code, wonder why it trim out 0000000100000000 - 0000000128000000 please try the attached debug patch in addtion to http://people.redhat.com/mingo/x86.git/README YH ------=_Part_11125_4975222.1209524456841 Content-Type: text/x-patch; name=trim_holes_fix.patch Content-Transfer-Encoding: base64 X-Attachment-Id: f_ffnbl6xz0 Content-Disposition: attachment; filename=trim_holes_fix.patch SW5kZXg6IGxpbnV4LTIuNi9hcmNoL3g4Ni9rZXJuZWwvY3B1L210cnIvbWFpbi5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIGxpbnV4LTIuNi5vcmlnL2FyY2gveDg2L2tlcm5lbC9jcHUvbXRyci9tYWluLmMKKysr IGxpbnV4LTIuNi9hcmNoL3g4Ni9rZXJuZWwvY3B1L210cnIvbWFpbi5jCkBAIC0xMTAzLDYgKzEx MDMsOSBAQCBzdGF0aWMgdTY0IF9faW5pdCByZWFsX3RyaW1fbWVtb3J5KHVuc2lnCiAJdHJpbV9z aXplID0gbGltaXRfcGZuOwogCXRyaW1fc2l6ZSA8PD0gUEFHRV9TSElGVDsKIAl0cmltX3NpemUg LT0gdHJpbV9zdGFydDsKKworCXByaW50ayhLRVJOX0lORk8gInRyaW0gZTgyMCB3aXRoIE1UUlIg TUFQIChVQyk6ICUwMTZseCAtICUwMTZseFxuIiwgc3RhcnRfcGZuLCBsaW1pdF9wZm4pOworCiAJ cmV0dXJuIHVwZGF0ZV9tZW1vcnlfcmFuZ2UodHJpbV9zdGFydCwgdHJpbV9zaXplLCBFODIwX1JB TSwKIAkJCQlFODIwX1JFU0VSVkVEKTsKIH0KQEAgLTExMjQsNyArMTEyNyw2IEBAIGludCBfX2lu aXQgbXRycl90cmltX3VuY2FjaGVkX21lbW9yeSh1bnMKIAlzdHJ1Y3QgcmVzX3JhbmdlIHJhbmdl W1JBTkdFX05VTV07CiAJaW50IG5yX3JhbmdlOwogCXU2NCB0b3RhbF9yZWFsX3RyaW1fc2l6ZTsK LQlpbnQgY2hhbmdlZDsKIAogCS8qIGV4dHJhIG9uZSBmb3IgYWxsIDAgKi8KIAlpbnQgbnVtW01U UlJfTlVNX1RZUEVTICsgMV07CkBAIC0xMTg5LDQ5ICsxMTkxLDM1IEBAIGludCBfX2luaXQgbXRy cl90cmltX3VuY2FjaGVkX21lbW9yeSh1bnMKIAl9CiAJbnJfcmFuZ2UgPSB4ODZfZ2V0X210cnJf bWVtX3JhbmdlKHJhbmdlLCBucl9yYW5nZSwgMCwgMCk7CiAKLQljaGFuZ2VkID0gMDsKLQl0b3Rh bF9yZWFsX3RyaW1fc2l6ZSA9IDA7Ci0KLQkvKiBjaGVjayB0aGUgdG9wIGF0IGZpcnN0ICovCi0J aSA9IG5yX3JhbmdlIC0gMTsKLQlpZiAocmFuZ2VbaV0uZW5kICsgMSA8IGVuZF9wZm4pIHsKLQkJ CXRvdGFsX3JlYWxfdHJpbV9zaXplICs9IHJlYWxfdHJpbV9tZW1vcnkocmFuZ2VbaV0uZW5kICsg MSwgZW5kX3Bmbik7Ci0JfQotCi0JaWYgKHRvdGFsX3JlYWxfdHJpbV9zaXplKSB7Ci0JCXByaW50 ayhLRVJOX1dBUk5JTkcgIldBUk5JTkc6IEJJT1MgYnVnOiBDUFUgTVRSUnMgZG9uJ3QgY292ZXIi Ci0JCQkiIGFsbCBvZiBtZW1vcnksIGxvc2luZyAlbGx1TUIgb2YgUkFNLlxuIiwKLQkJCXRvdGFs X3JlYWxfdHJpbV9zaXplID4+IDIwKTsKLQotCQlXQVJOX09OKDEpOwotCi0JCXByaW50ayhLRVJO X0lORk8gInVwZGF0ZSBlODIwIGZvciBtdHJyIC0tIGVuZF9wZm5cbiIpOwotCQl1cGRhdGVfZTgy MCgpOwotCQljaGFuZ2VkID0gMTsKLQl9Ci0KIAl0b3RhbF9yZWFsX3RyaW1fc2l6ZSA9IDA7CisJ LyogY2hlY2sgdGhlIGhlYWQgKi8KIAlpZiAocmFuZ2VbMF0uc3RhcnQpCiAJCXRvdGFsX3JlYWxf dHJpbV9zaXplICs9IHJlYWxfdHJpbV9tZW1vcnkoMCwgcmFuZ2VbMF0uc3RhcnQpOwotCi0JZm9y IChpID0gMDsgaSA8IG5yX3JhbmdlIC0gMTsgaS0tKSB7CisJLyogY2hlY2sgdGhlIGhvbGVzICov CisJZm9yIChpID0gMDsgaSA8IG5yX3JhbmdlIC0gMTsgaSsrKSB7CiAJCWlmIChyYW5nZVtpXS5l bmQgKyAxIDwgcmFuZ2VbaSsxXS5zdGFydCkKIAkJCXRvdGFsX3JlYWxfdHJpbV9zaXplICs9IHJl YWxfdHJpbV9tZW1vcnkocmFuZ2VbaV0uZW5kICsgMSwgcmFuZ2VbaSsxXS5zdGFydCk7CiAJfQor CS8qIGNoZWNrIHRoZSB0b3AgKi8KKwlpID0gbnJfcmFuZ2UgLSAxOworCWlmIChyYW5nZVtpXS5l bmQgKyAxIDwgZW5kX3BmbikKKwkJdG90YWxfcmVhbF90cmltX3NpemUgKz0gcmVhbF90cmltX21l bW9yeShyYW5nZVtpXS5lbmQgKyAxLCBlbmRfcGZuKTsKIAogCWlmICh0b3RhbF9yZWFsX3RyaW1f c2l6ZSkgewogCQlwcmludGsoS0VSTl9XQVJOSU5HICJXQVJOSU5HOiBCSU9TIGJ1ZzogQ1BVIE1U UlJzIGRvbid0IGNvdmVyIgogCQkJIiBhbGwgb2YgbWVtb3J5LCBsb3NpbmcgJWxsdU1CIG9mIFJB TS5cbiIsCiAJCQl0b3RhbF9yZWFsX3RyaW1fc2l6ZSA+PiAyMCk7CiAKLQkJV0FSTl9PTigxKTsK KwkJaWYgKGVuYWJsZV9tdHJyX2NsZWFudXAgPCAxKQorCQkJV0FSTl9PTigxKTsKIAotCQlwcmlu dGsoS0VSTl9JTkZPICJ1cGRhdGUgZTgyMCBmb3IgbXRyciAtLSBob2xlc1xuIik7CisJCXByaW50 ayhLRVJOX0lORk8gInVwZGF0ZSBlODIwIGZvciBtdHJyXG4iKTsKIAkJdXBkYXRlX2U4MjAoKTsK LQkJY2hhbmdlZCA9IDE7CisKKwkJcmV0dXJuIDE7CiAJfQogCi0JcmV0dXJuIGNoYW5nZWQ7CisJ cmV0dXJuIDA7CiB9CiAKIC8qKgpJbmRleDogbGludXgtMi42L2FyY2gveDg2L2tlcm5lbC9lODIw XzY0LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gbGludXgtMi42Lm9yaWcvYXJjaC94ODYva2VybmVsL2U4MjBf NjQuYworKysgbGludXgtMi42L2FyY2gveDg2L2tlcm5lbC9lODIwXzY0LmMKQEAgLTg0Niw2ICs4 NDYsOCBAQCB1NjQgX19pbml0IHVwZGF0ZV9tZW1vcnlfcmFuZ2UodTY0IHN0YXJ0CiAJCWlmIChl aS0+YWRkciA+PSBzdGFydCAmJiBlaS0+c2l6ZSA8PSBzaXplKSB7CiAJCQllaS0+dHlwZSA9IG5l d190eXBlOwogCQkJcmVhbF91cGRhdGVkX3NpemUgKz0gZWktPnNpemU7CisJCQlwcmludGsoS0VS Tl9JTkZPICJtb2RpZmllZCBwaHlzaWNhbCBSQU0gbWFwIC0gd2hvbGUgY292ZXIgd2l0aCAlZDpc biIsIGkpOworCQkJZTgyMF9wcmludF9tYXAoIm1vZGlmaWVkIik7CiAJCQljb250aW51ZTsKIAkJ fQogCQkvKiBwYXJ0aWFsbHkgY292ZXJlZCAqLwpAQCAtODU2LDYgKzg1OCw4IEBAIHU2NCBfX2lu aXQgdXBkYXRlX21lbW9yeV9yYW5nZSh1NjQgc3RhcnQKIAkJYWRkX21lbW9yeV9yZWdpb24oZmlu YWxfc3RhcnQsIGZpbmFsX2VuZCAtIGZpbmFsX3N0YXJ0LAogCQkJCQkgbmV3X3R5cGUpOwogCQly ZWFsX3VwZGF0ZWRfc2l6ZSArPSBmaW5hbF9lbmQgLSBmaW5hbF9zdGFydDsKKwkJcHJpbnRrKEtF Uk5fSU5GTyAibW9kaWZpZWQgcGh5c2ljYWwgUkFNIG1hcCAtIGFkZCBvbmUgd2l0aCAlZDpcbiIs IGkpOworCQllODIwX3ByaW50X21hcCgibW9kaWZpZWQiKTsKIAl9CiAJcmV0dXJuIHJlYWxfdXBk YXRlZF9zaXplOwogfQo= ------=_Part_11125_4975222.1209524456841--