public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Meneghini <jmeneghi@redhat.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	"kbusch@kernel.org" <kbusch@kernel.org>,
	"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>,
	"emilne@redhat.com" <emilne@redhat.com>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"jrani@purestorage.com" <jrani@purestorage.com>,
	"randyj@purestorage.com" <randyj@purestorage.com>,
	"hare@kernel.org" <hare@kernel.org>
Subject: Re: [PATCH v6 1/1] nvme-multipath: implement "queue-depth" iopolicy
Date: Wed, 12 Jun 2024 09:07:33 -0400	[thread overview]
Message-ID: <868707d5-bbe5-4f10-8395-333caa867a82@redhat.com> (raw)
In-Reply-To: <1307c447-65bb-430c-88e1-045191d8d8ba@nvidia.com>


On 6/11/24 21:44, Chaitanya Kulkarni wrote:
>>    /*
>>     * List of workarounds for devices that required behavior not specified in
>>     * the standard.
>> @@ -195,6 +197,7 @@ enum {
>>    	NVME_REQ_CANCELLED		= (1 << 0),
>>    	NVME_REQ_USERCMD		= (1 << 1),
>>    	NVME_MPATH_IO_STATS		= (1 << 2),
>> +	NVME_MPATH_CNT_ACTIVE	= (1 << 3),
> nit:- please align above to existing code ...

Ok... there must be something wrong with my tab stop.... are we using 8 space tabs in linux?

Here's what I have in my .vimrc

set smartindent              " always set smartindenting on
set autoindent               " always set autoindenting on
set backspace=2              " Influences the working of <BS>, <Del>, CTRL-W and CTRL-U in Insert mode.
set noexpandtab              " insert tabs instead of spaces
set textwidth=0              " Don't wrap words by default
set shiftwidth=4 smarttab    " number of spaces to use for each step of indent
set tabstop=4 softtabstop=0  " setting tab stops to be different from the indentation width

What is recommended setting for these ?

set shiftwidth=8 ?
set tabstop=8 ?

/John


  reply	other threads:[~2024-06-12 13:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12  0:20 [PATCH v6 0/1] nvme: queue-depth multipath iopolicy John Meneghini
2024-06-12  0:20 ` [PATCH v6 1/1] nvme-multipath: implement "queue-depth" iopolicy John Meneghini
2024-06-12  1:44   ` Chaitanya Kulkarni
2024-06-12 13:07     ` John Meneghini [this message]
2024-06-19 15:44     ` John Meneghini
2024-06-12  6:11   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868707d5-bbe5-4f10-8395-333caa867a82@redhat.com \
    --to=jmeneghi@redhat.com \
    --cc=chaitanyak@nvidia.com \
    --cc=emilne@redhat.com \
    --cc=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=jrani@purestorage.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=randyj@purestorage.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox