From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5526221F26; Wed, 26 Feb 2025 14:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579668; cv=none; b=TGMpFTd8S/zxsv7E83T6iFWgxK69me36PNCzCFIcJy2pNRqZRzdSTixwtTemqn8SrAQaEnueDQisyapv2Q3hT+THpzICU1QMRlfKCMztI+nGYUBMVTdQx3rdBE+fii/TP2pEHEIxCVkKpXi/gkmfs/CvN7D7aMLR3u38DxoJk0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740579668; c=relaxed/simple; bh=5ZVxX96Jefja2LWob2Q747PzTY5XxGREUDxPIe+lZtU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=XHgyYaZzlbCyX0phezyKCcMLatABAgaDj1fuLZjZsx1uvzg0GLTOyJBghQgL5YgPd9MDThkETUk0l6kCvVa/y4bsU/eBMtsx/+uD0fBABiEiI7EyR8bvIBr9wVOmrspv3Uyr117E2CsrEVjEKkg15/uBpBkZVc5FEw3CejhI9m8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j6d0dXSn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j6d0dXSn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35F51C4CEE4; Wed, 26 Feb 2025 14:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740579668; bh=5ZVxX96Jefja2LWob2Q747PzTY5XxGREUDxPIe+lZtU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=j6d0dXSn4+z/SBJM3vxhQu5qFzM6uDRQhTM7Q5gcbl08suWuDLdZCtHDVlOl2Yr/4 LHQABUMx6qu11rdrb1XTgAb0pq4CljQS+UTTfrERupSGuGppZ0hpcOUFW9ySUS3tlk nDUVwwmB8h3rNl/evx/6pjLFu3GvSIdYAOdhdU51HzU60nm9kxEvW3VAv7ixlXdYBT ZHMfvD15XLkZPjHsVsSP6IeTDN2yXDfta/T5QWOFYaz4I0IlEuVj5q2nL2R5TKIdLv aDqMM6UyQ8OxQwRrIK4I/plLa9rOsaH+TeVdf508OHuqqfp2iO9Ao1baOYm5zzJd7D XAeLdUwG5hqaA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tnIHZ-008D3e-Bx; Wed, 26 Feb 2025 14:21:05 +0000 Date: Wed, 26 Feb 2025 14:21:04 +0000 Message-ID: <868qpsrdm7.wl-maz@kernel.org> From: Marc Zyngier To: Quentin Perret Cc: Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] KVM: arm64: Don't WARN from __pkvm_host_share_guest() In-Reply-To: References: <20250225015327.3708420-1-qperret@google.com> <20250225015327.3708420-3-qperret@google.com> <87jz9d299h.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: qperret@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 25 Feb 2025 19:49:43 +0000, Quentin Perret wrote: > > On Tuesday 25 Feb 2025 at 18:02:02 (+0000), Marc Zyngier wrote: > > On Tue, 25 Feb 2025 01:53:25 +0000, > > Quentin Perret wrote: > > > > > > We currently WARN() if the host attempts to share a page that is not in > > > an acceptable state with a guest. This isn't strictly necessary and > > > makes testing much harder, so drop the WARN and fix the error code. > > > > Are you really fixing the error code? You still seem to return a > > -EPERM. I guess this was never reachable thanks to WARN() being a > > panic with pKVM? > > Exactly, this is really poor wording in the commit message. 'Fix the > error code' in this case was intended to mean 'make sure to return the > error code properly instead outright crashing the device'. > > Happy to send out a v3 with a better commit message. Nah, that's probably something Oliver can fixup when picking up the patch. Thanks, M. -- Without deviation from the norm, progress is not possible.