From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 764DB1DFE22; Wed, 19 Feb 2025 16:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739982158; cv=none; b=a9YkIOIVHB+ncPOst8CVC+r7lNTVV4qaFbC8rSPnOKRqJX9+/D+IywUzhUG/d1Snv4BwCc/RqLAOPOMHwBS1BM28cT/58gYQzY0GvB5OzxcuY9nAKp5VI9ugomsUcFDKB9QdJALfaDPYFE/aFwdhW1WETKbYwbLnXUQ+X4HTftE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739982158; c=relaxed/simple; bh=+BlKhVXGeiezjeGrHAuLK/twb425aHVJCEUYJtYaH1s=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=qtgckqRRqQ7jvEOM88K0Vy6izCf/s+JBwQUcJrCNudebPv4mJxqHCTRQtLCw36269NWWLh3kKsxYi5cLpTEtx6jVts9HpDhyXbxZl94yMDwANpfg075g7VjIZKiTZ0mQBX3kLwIuWu3qZ7rm+afaTnmZ1bzink0Z7RVD3BTkE5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r8qISNlj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r8qISNlj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7411C4CED1; Wed, 19 Feb 2025 16:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739982158; bh=+BlKhVXGeiezjeGrHAuLK/twb425aHVJCEUYJtYaH1s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=r8qISNljlZ8kPTwo5/KE82yeb93xT17PEwdHDCI7JBTq26CuAIf5w7/q79L0LnJVa uJMF+us3dA+7TS8Wngrj4QokXtoZ7FWzrsp+IRDwfKHgqX8m3PFKGRxysiA3cYK3NG 608HgQokUzdL3XkJNGLilgsE7TY1qFsamiPNS7pHPL8c5kAXgBd3Px/G0FeXcfMWlY fBmRYsN9j+GabDk6GnAXaPF2h4SZbT/b/yMnpEyCz7KxDt1vGhg7g0FaZB4PuRPZGd PA3vJfxua05bAvpG95UCcx+hh+q2uvyLvtIckZhEZdDOsXxeDrILWclQLx/NBh7hoH hCikICrII0vqA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tkmqH-005tUr-BB; Wed, 19 Feb 2025 16:22:33 +0000 Date: Wed, 19 Feb 2025 16:22:32 +0000 Message-ID: <868qq1sy47.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Mingwei Zhang , Colton Lewis , Raghavendra Rao Ananta , Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Janne Grunau Subject: Re: [PATCH v2 01/14] drivers/perf: apple_m1: Refactor event select/filter configuration In-Reply-To: <20250203183111.191519-2-oliver.upton@linux.dev> References: <20250203183111.191519-1-oliver.upton@linux.dev> <20250203183111.191519-2-oliver.upton@linux.dev> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, mizhang@google.com, coltonlewis@google.com, rananta@google.com, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, j@jannau.net X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 03 Feb 2025 18:30:58 +0000, Oliver Upton wrote: > > Supporting guest mode events will necessitate programming two event > filters. Prepare by splitting up the programming of the event selector + > event filter into separate headers. s/headers/helpers/ ? > > Opportunistically replace RMW patterns with sysreg_clear_set_s(). > > Tested-by: Janne Grunau > Signed-off-by: Oliver Upton > --- > arch/arm64/include/asm/apple_m1_pmu.h | 1 + > drivers/perf/apple_m1_cpu_pmu.c | 52 ++++++++++++++++----------- > 2 files changed, 33 insertions(+), 20 deletions(-) > > diff --git a/arch/arm64/include/asm/apple_m1_pmu.h b/arch/arm64/include/asm/apple_m1_pmu.h > index 99483b19b99f..02e05d05851f 100644 > --- a/arch/arm64/include/asm/apple_m1_pmu.h > +++ b/arch/arm64/include/asm/apple_m1_pmu.h > @@ -37,6 +37,7 @@ > #define PMCR0_PMI_ENABLE_8_9 GENMASK(45, 44) > > #define SYS_IMP_APL_PMCR1_EL1 sys_reg(3, 1, 15, 1, 0) > +#define SYS_IMP_APL_PMCR1_EL12 sys_reg(3, 1, 15, 7, 2) nit: this should be moved to the following patch. Otherwise looks good to me. M. -- Without deviation from the norm, progress is not possible.