From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D474199FC2; Fri, 30 Aug 2024 12:28:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725020920; cv=none; b=Dc1PT8WXAVHeKvIB/v6wB+ZoTxjM1KnXjz+zwhsQ6NvhCtfppXK8NQL7o7xBn3ApcLHut6CeMAkCOoZGRPmCudXNxgpjnB32UiUF0/CUmUESc1JT/8Zcrq9vAoywMJnNf/4ukh6e2+wx94QDR/Q2zPo1zc+RJm2vYOwIh3mcHeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725020920; c=relaxed/simple; bh=zO4wCnBxkRXI4i7T5gLDq8jp8Mqm7VeBGA6ulGBi90g=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=WYEYgc5opKenxYK579Zch+IJuc3bbikV9oVWcc0y4ErK0vWYDG8Hqbh3Nky9NOHvt7DJqkBMguNT2Rn5BExZBL1ksykFseYJlrUq1Bba4Mv52ocEftrRK9C1Pd5M3eeFXSr1m301Z28Y4sGYUrM04GoGTfqJy9Sd8Jr137Iyk4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uMGTTGx8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uMGTTGx8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96B95C4CEC8; Fri, 30 Aug 2024 12:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725020919; bh=zO4wCnBxkRXI4i7T5gLDq8jp8Mqm7VeBGA6ulGBi90g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uMGTTGx8s5zmmy3/df69HrZEHIrifn0gDansnbCAJgTGbTtDclef3IKWPrpklEnPr ELsNmyQs8e69sUiNCtm/TkT0WXtdqF9hheMKjklQ8C1Kkh/6C9oCFkmU0QjkaN5AaM AUcrHUyqdMutMujyrs0nVmeXggVkztoWHE3rFppU+7lecAUWcziH7YdOSDOWWQQZyB oTzcFdhR8/khxQyd3V0JenFzXGwf8Br6rvPNfCW08bDJim1Ltc/HeUlyywyqY/Z1kM Ln8ygNn+e3DfuSpYf0/tKWADFAJILzYQ6i+xpbKbnJgwNN4A/0fp73lIKR+8zLOsy7 Z3t6HLh+c+jDA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sk0k1-008EPI-01; Fri, 30 Aug 2024 13:28:37 +0100 Date: Fri, 30 Aug 2024 13:28:36 +0100 Message-ID: <868qwew5xn.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Ene Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v9 2/5] arm64: ptdump: Expose the attribute parsing functionality In-Reply-To: <20240827084549.45731-3-sebastianene@google.com> References: <20240827084549.45731-1-sebastianene@google.com> <20240827084549.45731-3-sebastianene@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastianene@google.com, akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, vdonnefort@google.com, mark.rutland@arm.com, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 27 Aug 2024 09:45:45 +0100, Sebastian Ene wrote: > > Reuse the descriptor parsing functionality to keep the same output format > as the original ptdump code. This sentence seems either out of place or missing something, because this change it not reusing anything... > In order for this to happen, move the state > tracking objects into a common header. ... but instead doing this ^^^. I propose to rewrite the commit message as: "Adding a new page-table dumper for stage-2 requires parsing the page tables, and reusing the descriptor parsing functionality would help keeping the same output format as the original ptdump code. In order for this to happen, move the state tracking object definitions into a common header." Shout if you object to it! Thanks, M. -- Without deviation from the norm, progress is not possible.