From: Marc Zyngier <maz@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
Julia Lawall <julia.lawall@lip6.fr>,
kernel-janitors@vger.kernel.org,
Coccinelle <cocci@systeme.lip6.fr>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Thomas Gleixner <tglx@linutronix.de>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: coccinelle: api/devm_platform_ioremap_resource: remove useless script
Date: Sat, 19 Oct 2019 21:43:05 +0100 [thread overview]
Message-ID: <868spgzcti.wl-maz@kernel.org> (raw)
In-Reply-To: <693a3b68-a0f1-81fe-40ce-2b6ba189450c@web.de>
On Sat, 19 Oct 2019 12:35:49 +0100,
Markus Elfring <Markus.Elfring@web.de> wrote:
>
> > I think part of the issue is that the script reports a WARNING
>
> How much does this information influence really the stress tolerance
> and change resistance (or acceptance) for the presented collateral evolution?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/scripts/coccinelle/api/devm_platform_ioremap_resource.cocci
-ENOPARSE.
> > for something that is definitely correct code,
>
> Can related software improvement possibilities be taken into account
> again under other circumstances?
These patches provide no improvement whatsoever. As pointed out, they
mostly introduce bugs.
> > and could instead be simply toned down.
>
> Does this view mean that the mentioned script for the semantic patch language
> should get another chance for integration?
Providing Coccinelle scripts that scream about perfectly valid code is
pointless, and the result is actively harmful.
If said script was providing a correct semantic patch instead of being
an incentive for people to churn untested patches that span the whole
tree, that'd be a different story. But that's not what this is about.
> > Anyway, FWIW:
> >
> > Acked-by: Marc Zyngier <maz@kernel.org>
>
> Would you like to share any more constructive feedback?
No.
> Will similar source file mass updates be better picked up
> by other well-known Linux developers?
Certainly not for the subsystems I maintain.
M.
--
Jazz is not dead, it just smells funny.
next prev parent reply other threads:[~2019-10-19 20:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 14:22 [PATCH] coccinelle: api/devm_platform_ioremap_resource: remove useless script Alexandre Belloni
2019-10-17 14:34 ` Julia Lawall
2019-10-17 16:13 ` Marc Zyngier
2019-10-19 11:35 ` Markus Elfring
2019-10-19 20:43 ` Marc Zyngier [this message]
2019-10-19 22:13 ` Joe Perches
2019-10-24 15:40 ` Masahiro Yamada
2019-10-24 18:30 ` Markus Elfring
2019-10-25 8:08 ` Andy Shevchenko
2019-10-25 8:38 ` Julia Lawall
2019-10-29 2:58 ` Masahiro Yamada
2019-10-29 8:55 ` Julia Lawall
2019-10-20 5:38 ` Julia Lawall
2019-10-20 9:34 ` Marc Zyngier
2019-10-20 5:45 ` Markus Elfring
2019-10-19 9:00 ` [PATCH] " Markus Elfring
2019-10-19 12:09 ` Alexandre Belloni
2019-10-19 14:06 ` Markus Elfring
2019-10-19 14:29 ` [PATCH] " Bartosz Golaszewski
2019-10-19 16:36 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868spgzcti.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=Gilles.Muller@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=torvalds@linuxfoundation.org \
--cc=yamada.masahiro@socionext.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox