linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Documentation <linux-doc@vger.kernel.org>,
	Linux GFS2 <gfs2@lists.linux.dev>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Darrick J. Wong" <djwong@kernel.org>,
	Jeff Layton <jlayton@kernel.org>,
	Miklos Szeredi <mszeredi@redhat.com>, Jan Kara <jack@suse.cz>,
	Christian Brauner <brauner@kernel.org>,
	Chen Linxuan <chenlinxuan@uniontech.com>,
	James Morse <james.morse@arm.com>,
	Bernd Schubert <bschubert@ddn.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH v2] Documentation: gfs2: Consolidate GFS2 docs into its own subdirectory
Date: Tue, 26 Aug 2025 20:18:57 -0700	[thread overview]
Message-ID: <8696a6c8-c555-4523-b8dc-b41ab14b4380@infradead.org> (raw)
In-Reply-To: <20250827022122.12132-1-bagasdotme@gmail.com>



On 8/26/25 7:21 PM, Bagas Sanjaya wrote:
> Documentation for GFS2 is scattered in three docs that are in
> Documentation/filesystems/ directory. As these docs are standing out as
> a group, move them into separate gfs2/ subdirectory.
> 
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Changes since v1 [1]:
> 
>    * Strip gfs2- prefix (Matthew)
> 
>  [1]: https://lore.kernel.org/linux-doc/20250826023913.14888-1-bagasdotme@gmail.com/
> 
>  .../filesystems/{gfs2-glocks.rst => gfs2/glocks.rst} |  0
>  Documentation/filesystems/gfs2/index.rst             | 12 ++++++++++++
>  .../filesystems/{gfs2.rst => gfs2/overview.rst}      |  6 +++---
>  .../{gfs2-uevents.rst => gfs2/uevents.rst}           |  0
>  Documentation/filesystems/index.rst                  |  4 +---
>  MAINTAINERS                                          |  2 +-
>  6 files changed, 17 insertions(+), 7 deletions(-)
>  rename Documentation/filesystems/{gfs2-glocks.rst => gfs2/glocks.rst} (100%)
>  create mode 100644 Documentation/filesystems/gfs2/index.rst
>  rename Documentation/filesystems/{gfs2.rst => gfs2/overview.rst} (96%)
>  rename Documentation/filesystems/{gfs2-uevents.rst => gfs2/uevents.rst} (100%)
> 
> diff --git a/Documentation/filesystems/gfs2-glocks.rst b/Documentation/filesystems/gfs2/glocks.rst
> similarity index 100%
> rename from Documentation/filesystems/gfs2-glocks.rst
> rename to Documentation/filesystems/gfs2/glocks.rst
> diff --git a/Documentation/filesystems/gfs2/index.rst b/Documentation/filesystems/gfs2/index.rst
> new file mode 100644
> index 00000000000000..9d9ca84d45a7ae
> --- /dev/null
> +++ b/Documentation/filesystems/gfs2/index.rst
> @@ -0,0 +1,12 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +====================
> +Global File System 2
> +====================
> +
> +.. toctree::
> +   :maxdepth: 1
> +
> +   overview
> +   glocks
> +   uevents
> diff --git a/Documentation/filesystems/gfs2.rst b/Documentation/filesystems/gfs2/overview.rst
> similarity index 96%
> rename from Documentation/filesystems/gfs2.rst
> rename to Documentation/filesystems/gfs2/overview.rst
> index 1bc48a13430c1c..f971353d23611c 100644
> --- a/Documentation/filesystems/gfs2.rst
> +++ b/Documentation/filesystems/gfs2/overview.rst
> @@ -1,8 +1,8 @@
>  .. SPDX-License-Identifier: GPL-2.0
>  
> -====================
> -Global File System 2
> -====================
> +=============
> +GFS2 Overview
> +=============
>  
>  GFS2 is a cluster file system. It allows a cluster of computers to
>  simultaneously use a block device that is shared between them (with FC,
> diff --git a/Documentation/filesystems/gfs2-uevents.rst b/Documentation/filesystems/gfs2/uevents.rst
> similarity index 100%
> rename from Documentation/filesystems/gfs2-uevents.rst
> rename to Documentation/filesystems/gfs2/uevents.rst
> diff --git a/Documentation/filesystems/index.rst b/Documentation/filesystems/index.rst
> index 11a599387266a4..897eabaa30d65d 100644
> --- a/Documentation/filesystems/index.rst
> +++ b/Documentation/filesystems/index.rst
> @@ -90,9 +90,7 @@ Documentation for filesystem implementations.
>     ext3
>     ext4/index
>     f2fs
> -   gfs2
> -   gfs2-uevents
> -   gfs2-glocks
> +   gfs2/index
>     hfs
>     hfsplus
>     hpfs
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dafc1171254406..c685140f78c4e9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10335,7 +10335,7 @@ L:	gfs2@lists.linux.dev
>  S:	Supported
>  B:	https://bugzilla.kernel.org/enter_bug.cgi?product=File%20System&component=gfs2
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git
> -F:	Documentation/filesystems/gfs2*
> +F:	Documentation/filesystems/gfs2/*

I think this should be:

F:	Documentation/filesystems/gfs2/

without the trailing '*'.

See the explanation for F: near the top of the MAINTAINERS file.

>  F:	fs/gfs2/
>  F:	include/uapi/linux/gfs2_ondisk.h
>  
> 
> base-commit: ee9a6691935490dc39605882b41b9452844d5e4e


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

thanks.

-- 
~Randy

      reply	other threads:[~2025-08-27  3:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27  2:21 [PATCH v2] Documentation: gfs2: Consolidate GFS2 docs into its own subdirectory Bagas Sanjaya
2025-08-27  3:18 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8696a6c8-c555-4523-b8dc-b41ab14b4380@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=agruenba@redhat.com \
    --cc=bagasdotme@gmail.com \
    --cc=bhelgaas@google.com \
    --cc=brauner@kernel.org \
    --cc=bschubert@ddn.com \
    --cc=chenlinxuan@uniontech.com \
    --cc=corbet@lwn.net \
    --cc=djwong@kernel.org \
    --cc=gfs2@lists.linux.dev \
    --cc=jack@suse.cz \
    --cc=james.morse@arm.com \
    --cc=jlayton@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).