From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, alim.akhtar@samsung.com,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
andre.draszik@linaro.org, kernel-team@android.com,
willmcvicker@google.com, peter.griffin@linaro.org
Subject: Re: [PATCH v3 1/3] dt-bindings: mailbox: add bindings for samsung,exynos
Date: Mon, 9 Dec 2024 15:32:31 +0100 [thread overview]
Message-ID: <8698ccfc-9c16-4b4e-b526-66efd39c0134@kernel.org> (raw)
In-Reply-To: <38e6687e-c2ee-414b-bba5-483150ba7baa@linaro.org>
On 09/12/2024 15:19, Tudor Ambarus wrote:
>
>
> On 12/9/24 8:33 AM, Krzysztof Kozlowski wrote:
>>> I'm thinking of using the same driver for both cases, and differentiate
>>> between the two by compatible and `of_device_id.data`. Thus I propose to
>>> have a "google,gs101-acpm-mbox" compatible for the ACPM SRAM case and in
>>> the future we may add a "google,gs101-mbox" compatible for the messages
>>> passed via the controller's data register case.
>> Good that you pointed it out, I was indeed wondering why this is
>> "acpm-mbox", not "mbox in compatible.
>>
>> This needs to be fixed - you cannot have two compatibles for the same
>> device.
>
> Will fix. I followed arm,mhu, which differentiates the transfer mode,
> data or doorbell, via compatible.
There was a reasoning behind: different firmware.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-09 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 17:41 [PATCH v3 0/3] mailbox: add samsung exynos driver Tudor Ambarus
2024-12-05 17:41 ` [PATCH v3 1/3] dt-bindings: mailbox: add bindings for samsung,exynos Tudor Ambarus
2024-12-09 7:52 ` Krzysztof Kozlowski
2024-12-09 8:11 ` Tudor Ambarus
2024-12-09 8:33 ` Krzysztof Kozlowski
2024-12-09 14:19 ` Tudor Ambarus
2024-12-09 14:32 ` Krzysztof Kozlowski [this message]
2024-12-05 17:41 ` [PATCH v3 2/3] mailbox: add samsung exynos driver Tudor Ambarus
2024-12-09 7:55 ` Krzysztof Kozlowski
2024-12-05 17:41 ` [PATCH v3 3/3] MAINTAINERS: add entry for samsung exynos mailbox driver Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8698ccfc-9c16-4b4e-b526-66efd39c0134@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox