Re: [PATCH 12/25] genirq: Factor-in percpu irqaction creation

Thomas Gleixner
2025-09-09T09:41:47Z

On Mon, Sep 08 2025 at 17:31, Marc Zyngier wrote:
>
> +static
> +struct irqaction *create_percpu_irqaction(irq_handler_t handler,
> + unsigned long flags,
> + const char *devname,
> + void __percpu *dev_id)

static struct irqaction *create_percpu_irqaction(irq_handler_t handler, unsigned long flags,
const char *devname, void __percpu *dev_id)
{

No?

> +{
> + struct irqaction *action;
> +
> + action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);

struct irqaction *action = kzalloc(sizeof(*action),.....;
> - action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);
> + action = create_percpu_irqaction(handler,
> + IRQF_NO_THREAD | IRQF_NOBALANCING,
> + name, dev_id);

Please get rid of these artifical line breaks. You have 100 characters.

Thanks,

tglx