From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7217B657; Sat, 17 Aug 2024 10:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723890345; cv=none; b=eKrG9x+7usGBNxG4NEiKcNcrVk20vu2RWDZVw9pOTQu+QlTcNoigvSSWLg0k6xRjFE/zthPzDOLf/4eQ/KGPJ3mKHsC144Q5j0XM8qtsuTFenTcXwFG9E3b0O3sHfkzYQ+iagUMu9u5GBbFvo8x5YgrOFXXLkJeeltk8oC49VU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723890345; c=relaxed/simple; bh=DHhe3pmtDxyRax9ygVaZwi+haQX8zawBPIakTdO65OU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=kMUGlwNgoT4Fe7euzf129TocG+B3zBd92QC5old6vjDIOgYVj5+f6nuuisExNG/1xPNL7o/UdqkwjI2PLJ5qqFtJW3NrAy+g0AWSPiWpfuR8PiAAezoAfvXXVtCROwj0OZyE5Tg/1nUy2mWMgfn8XJXdMiVJZKUqKhUtjMOIHIk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X1uZUHiE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X1uZUHiE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32F01C116B1; Sat, 17 Aug 2024 10:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723890345; bh=DHhe3pmtDxyRax9ygVaZwi+haQX8zawBPIakTdO65OU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=X1uZUHiEhv04V2Z9T7Ey1pL2Ih2gnasu7T5IuEMEwQ8lOHweIsVlQKl17TW68jzIF 0PIBCnwAcmU9GGeM55o0tj+nMe+fwmBWuKc3RETFMPYBWbVY/pQ9bdq/aAFkksYPEa 8+e+8R/xjssLoRXBKPK2WR7E+AeQChlPCU80Ak+Dms9l3aNiBUB9hvqkasOFxxAmLW Ty+I/pbP2X9aAZg06HXUMOFfgpTqZCCIh9n9BlDsrLkSw668JhTk18SF7WTcjZgBRR 5xmb3RUbqMM23X/YXCo6LdjYC5NNGHWmfZJZFhs4KVCH6jRNcqnilfkp6XyuJYVw1D z3drnIZYCLuFA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sfGcx-004Vcv-00; Sat, 17 Aug 2024 11:25:43 +0100 Date: Sat, 17 Aug 2024 11:25:42 +0100 Message-ID: <86a5hbzbrt.wl-maz@kernel.org> From: Marc Zyngier To: Zenghui Yu Cc: , , , , , , Subject: Re: [PATCH] KVM: arm64: vgic-debug: Don't put unmarked LPIs In-Reply-To: <20240817101541.1664-1-yuzenghui@huawei.com> References: <20240817101541.1664-1-yuzenghui@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, wanghaibin.wang@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 17 Aug 2024 11:15:41 +0100, Zenghui Yu wrote: > > If there were LPIs being mapped behind our back (i.e., between .start() and > .stop()), we would put them at iter_unmark_lpis() without checking if they > were actually *marked*, which is obviously not good. > > Switch to use the xa_for_each_marked() iterator to fix it. > > Fixes: 85d3ccc8b75b ("KVM: arm64: vgic-debug: Use an xarray mark for debug iterator") > Signed-off-by: Zenghui Yu > --- > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index bc74d06398ef..e1397ab2072a 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -85,7 +85,7 @@ static void iter_unmark_lpis(struct kvm *kvm) > struct vgic_irq *irq; > unsigned long intid; > > - xa_for_each(&dist->lpi_xa, intid, irq) { > + xa_for_each_marked(&dist->lpi_xa, intid, irq, LPI_XA_MARK_DEBUG_ITER) { > xa_clear_mark(&dist->lpi_xa, intid, LPI_XA_MARK_DEBUG_ITER); > vgic_put_irq(kvm, irq); > } Ouch. Nicely caught. I think this deserves a Cc: stable@vger.kernel.org # v6.10 With that, Reviewed-by: Marc Zyngier Thanks, M. -- Without deviation from the norm, progress is not possible.