From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE78627447; Fri, 5 Apr 2024 10:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712312141; cv=none; b=lkdpI9PEIPGR7O+A0e3AkcH6OBPKlML4AHKjPj8bsEjaTSoRPKGbINYe6KTymEGUyc3auxyf7XVn3kD837V4VSbGmh6UDRcg2PTMSy2Nu3Des0YH7pPFXvVpjawhBbPpbs+DfmnKzGejSzwhxXR+JZQTGsHanOFvF3Ve3341kXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712312141; c=relaxed/simple; bh=ES+fMkXqFNZ+dS5Glpq+vFaKhveIj+TsprmaPhnsttI=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=kyJ6aXoC7Xf1ayFgokyT29A0eKqq6HJMS06BYSY33J46EDtfMOgCHFjixo6irLTNiAk7FN2Cjc9iNQzi4k5kEAJgZOgQXRKnkCcwuEinFM0HHZxGH4hnp4/bMdRr1G/ZAr55cHTYyjxiCFcksTZNR+26DJY/YjDoLUH1gvsry3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UhRN5pR7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UhRN5pR7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 768B3C43390; Fri, 5 Apr 2024 10:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712312140; bh=ES+fMkXqFNZ+dS5Glpq+vFaKhveIj+TsprmaPhnsttI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UhRN5pR75krC2i2PczKh4F20/cl7rTx658VXlRQm/+7Hwm37qaVwkDTJbAvX5z24X m0st4Hp2cR8QtS9uoFUlHrhARSVLDd9T3/wj1+Io5XH/7rmPbiaPbad8zFSfgSz0eS nzIyCBZpKQlOECQqrtIQPqiGzsoEdBzmeko/EOPiujHhRkzgjXHj+g8XBaiZZFOwqB X81ji+Vz6t+AE5Eu/9KRV0ha1vyiUtYGNr7g6nveE0wRVaYl1tvXfApA8KL4FbGLWM La6rKn4u0CGpVBakfLOAcD5jWcZg6wOF+VnUWBDpjs7dH5iwzXd9umqAUzQBqQzAPv SoOcmbs3zl2QQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rsgbi-001m8K-7O; Fri, 05 Apr 2024 11:15:38 +0100 Date: Fri, 05 Apr 2024 11:15:37 +0100 Message-ID: <86a5m8t8s6.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Jonathan Corbet , Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Mark Brown , Mark Rutland , kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [RFC 5/8] KVM: arm64: Explicitly handle MDSELR_EL1 traps as UNDEFINED In-Reply-To: <20240405080008.1225223-6-anshuman.khandual@arm.com> References: <20240405080008.1225223-1-anshuman.khandual@arm.com> <20240405080008.1225223-6-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, corbet@lwn.net, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, broonie@kernel.org, mark.rutland@arm.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 05 Apr 2024 09:00:05 +0100, Anshuman Khandual wrote: > > Currently read_sanitised_id_aa64dfr0_el1() caps the ID_AA64DFR0.DebugVer to > ID_AA64DFR0_DebugVer_V8P8, resulting in FEAT_Debugv8p9 not being exposed to > the guest. MDSELR_EL1 register access in the guest, is currently trapped by > the existing configuration of the fine-grained traps. Please add support for the HDFGxTR2_EL2 registers in the trap routing arrays, add support for the corresponding FGUs in the corresponding structure, and condition the UNDEF on the lack of *guest* support for the feature. In short, implement the architecture as described in the pseudocode, and not a cheap shortcut. Thanks, M. -- Without deviation from the norm, progress is not possible.