Re: [PATCH v5 5/6] HID: add spi-hid, transport driver for HID over SPI bus

Randy Dunlap
2022-07-07T20:51:39Z

Hi--

On 7/7/22 09:59, Jarrett Schultz wrote:
> From: Jarrett Schultz <jaschultz@microsoft.com>
>
> This driver follows HID Over SPI Protocol Specification 1.0 available at
> https://www.microsoft.com/en-us/download/details.aspx?id=103325. The
> initial version of the driver does not support: 1) multi-fragment input
> reports, 2) sending GET_INPUT and COMMAND output report types and
> processing their respective acknowledge input reports, and 3) device
> sleep power state.
>
> Signed-off-by: Dmitry Antipov <dmanti@microsoft.com>

Missing your (Jarrett's) Signed-off-by: here.

More below...

> ---
> drivers/hid/Kconfig | 2 +
> drivers/hid/Makefile | 1 +
> drivers/hid/spi-hid/Kconfig | 25 +
> drivers/hid/spi-hid/Makefile | 12 +
> drivers/hid/spi-hid/spi-hid-core.c | 1326 +++++++++++++++++++++++++++
> drivers/hid/spi-hid/spi-hid-core.h | 188 ++++
> drivers/hid/spi-hid/spi-hid-of.c | 141 +++
> drivers/hid/spi-hid/spi-hid-of.h | 30 +
> drivers/hid/spi-hid/spi-hid_trace.h | 194 ++++
> drivers/hid/spi-hid/trace.c | 9 +
> 10 files changed, 1928 insertions(+)
> create mode 100644 drivers/hid/spi-hid/Kconfig
> create mode 100644 drivers/hid/spi-hid/Makefile
> create mode 100644 drivers/hid/spi-hid/spi-hid-core.c
> create mode 100644 drivers/hid/spi-hid/spi-hid-core.h
> create mode 100644 drivers/hid/spi-hid/spi-hid-of.c
> create mode 100644 drivers/hid/spi-hid/spi-hid-of.h
> create mode 100644 drivers/hid/spi-hid/spi-hid_trace.h
> create mode 100644 drivers/hid/spi-hid/trace.c
>

> diff --git a/drivers/hid/spi-hid/Kconfig b/drivers/hid/spi-hid/Kconfig
> new file mode 100644
> index 000000000000..37302d658162
> --- /dev/null
> +++ b/drivers/hid/spi-hid/Kconfig
> @@ -0,0 +1,25 @@
> +#
> +# Copyright (c) 2021 Microsoft Corporation
> +#
> +# This program is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU General Public License version 2 as published by
> +# the Free Software Foundation.
> +#

Please just use SPDX tags instead of all of that.
See other hid/Kconfig files for examples.

> +menu "SPI HID support"
> + depends on SPI
> +
> +config SPI_HID
> + tristate "HID over SPI transport layer"
> + default n
> + depends on SPI && INPUT && OF
> + select HID
> + help
> + Say Y here if you use a keyboard, a touchpad, a touchscreen, or any
> + other HID based devices which is connected to your computer via SPI.

HID-based devices which are connected
(or)
HID-based device which is connected

> +
> + If unsure, say N.
> +
> + This support is also available as a module. If so, the module
> + will be called spi-hid.
> +
> +endmenu

--
~Randy