From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544B41E4AF for ; Mon, 12 Jan 2026 13:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768224684; cv=none; b=kML3nZCLulgW7qq6rD4st1ad0GxSEqDvLcYQ0e2Y9FhpHltCT6N0JEbg26H/09Um4/1CioGRCiT2yTQaNbQ5Nsm8QFN3GvuKbM7hsiN84lRxW9cW8SRE1lMicYGJtwDBr7PfZrwEO1Eov0+k/wfm1WwLPuaNmi6NmOAwFJwNBP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768224684; c=relaxed/simple; bh=IvRuR/u1t/U+ODZn8JoJlCSewXAZyKKQ2Z3JJthN8tU=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=qeMbHFmR5EeL0JXIJouNZwtVd+H2jV1NfKsjuuL7d/rB/ERDrs+rP3nfKFyFWEmzwKrg57n0+630m6jjd4OqFZOFT3yYku1Yf3jah7sygn+2QNinFfo8/7GvAod2h6CAsa7Ht6yzBArXzR1tfloHjVcuCVwOIijobO7eQ36Cda0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KtZJwFrR; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KtZJwFrR" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-81f42cd476eso34603b3a.3 for ; Mon, 12 Jan 2026 05:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768224682; x=1768829482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=/PipOGdMf07goSto3xV6V2h0Ud3tUjt4vk9HBm9j3g4=; b=KtZJwFrRAB6gpy5Ll6YBY90d+DEzPVAeAAJeSrJ+AQrub1LqlKgUsJEx48qOMUkA2u E6XU9/TKVsZBIpBoAQcwk3ImwpPouQ+n7YhEwsXXhfVDsQUYdiZDcNyUdWyEod7ifU4t VYOt+UHLThQ65d7ZM87tJziGB5NqcQHcOfDdF6hVR0pfaYt1nnW/chqzr9E5Qt3zpo1k EGFnmy59Ha9k65KFoZUndy5RQwHZNDnIcpv67m9IYMuhqbMYS8UhtVh6QlWrAmGfUkLO VFvK28g4mZrA1DRbU8Mlx0bOXrDjv6nszRsQCAl3zDn5lPV4BgHIz/C0W60uiPzdHMjm AX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768224682; x=1768829482; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/PipOGdMf07goSto3xV6V2h0Ud3tUjt4vk9HBm9j3g4=; b=Wsx+HOSlCWTDSHyQ26HHs4sDP+2bfJCzaLvU0De4mDDo6t7fMLTOGiwW/3rWApY9pJ 1T5fTa0d/HkNO7YRam+UiXjYcIsupCmwwbMDfdhrV1VnC9hpTGsqQIkSm6ANkd+4E3VX iNpT6ViTVgjzw5o+W9WTILACs5AjJ63dU7+dsz0Rf2t4209/2qvV6Wh71H5mmT5oPUbT cpEEJHekG504VodP+uh5e3cavb7CqO8sySrIzJh80FrM0O2Z6dL1HfiNPvoq3D0pgkXL XuiVmC/i92vlr4JE3TBbqDBddu9pKEbnxeLOEEo/us+hE8sl89zTs7yK5Kps6mMlg9nP gTqw== X-Gm-Message-State: AOJu0YyG3CGoTd06RTrgOEwekJN0iV4rGnFtats6J3bJ95yI/VB9qu3T qJZusOx+ngw20e7fPcuDEGaSXIJ8hPMWyIMBQ2sLaCJ1JJq4+ilXCyFeZWaSX68N X-Gm-Gg: AY/fxX7VGuipoGxM9sTqv72m5BOInRA+srrGYBdi77Ni+1Y1UFspAIiNc4maHsGNM2h iGeAEertcVWjZl3NYT0ZdVv+Z2vghjg8GmQ7xWiG98Osvcy6sE73RyHwlreUdNTlcTVNrxvfXnb 79W4OMSd369lVU65sD3/1TVR3ES7pXnrFaguYEOnx9LNRazVCtPBtpRvknGE9jGrUn7xdonYDwI XkAUu21pd9a60duHdwhHzGz/bkwEWiOF8UmAyXOxyjiboi794Oc0Nf1c4XU09/tbhVBHAje2Y1x OCgWXcAqHmfzRINhzSFf6L7kvYLcZTWaAJH4dXLqIh5Ozd1kjD9objPGg0kUqlsosfe+et/BpJ+ y7LcUrDTOe5ivK1UZ8SDW9kPJXKjjcsFqnyeFL0JB3KZzbDSApoqfvE7mJnP1Flur0sSFi+Rg7C eyU6rGlWCmOes3I9XMwg== X-Google-Smtp-Source: AGHT+IE4SuIy2Fo34RQ51O2BUDaNAwWp4QtK5Ka3V9h5k6xwfQMNDL1w6vGaPaBEmyy7OIQYdhPCTA== X-Received: by 2002:a05:6a00:1acb:b0:81f:475a:d242 with SMTP id d2e1a72fcca58-81f475ad32bmr3220064b3a.4.1768224681586; Mon, 12 Jan 2026 05:31:21 -0800 (PST) Received: from [172.20.48.71] ([47.246.98.222]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81e7cdaa87bsm8884840b3a.17.2026.01.12.05.31.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jan 2026 05:31:21 -0800 (PST) Message-ID: <86bdd498-2012-4bb1-956b-47d91c2a334e@gmail.com> Date: Mon, 12 Jan 2026 21:31:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [usb?] INFO: task hung in i2c_tiny_usb_disconnect To: syzbot References: <6963d09e.050a0220.eaf7.0070.GAE@google.com> Content-Language: en-US From: Wei Peng Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org In-Reply-To: <6963d09e.050a0220.eaf7.0070.GAE@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit |Sorry! Please ignore the previous patch. It was sent by mistake. The correct patch is attached below. |#syz test diff --git a/drivers/i2c/busses/i2c-tiny-usb.c b/drivers/i2c/busses/i2c-tiny-usb.c index 57dfe5f1a7d9..79b7c97514c9 100644 --- a/drivers/i2c/busses/i2c-tiny-usb.c +++ b/drivers/i2c/busses/i2c-tiny-usb.c @@ -12,6 +12,7 @@ #include #include #include +#include /* include interfaces to usb layer */ #include @@ -172,6 +173,8 @@ struct i2c_tiny_usb { struct usb_device *usb_dev; /* the usb device for this device */ struct usb_interface *interface; /* the interface for this device */ struct i2c_adapter adapter; /* i2c related things */ + bool disconnected; /* set to true on disconnect */ + struct work_struct release_work; /* work struct to release the adapter */ }; static int usb_read(struct i2c_adapter *adapter, int cmd, @@ -184,6 +187,11 @@ static int usb_read(struct i2c_adapter *adapter, int cmd, if (!dmadata) return -ENOMEM; + if (READ_ONCE(dev->disconnected)) { + kfree(dmadata); + return -ENODEV; + } + /* do control transfer */ ret = usb_control_msg(dev->usb_dev, usb_rcvctrlpipe(dev->usb_dev, 0), cmd, USB_TYPE_VENDOR | USB_RECIP_INTERFACE | @@ -204,6 +212,11 @@ static int usb_write(struct i2c_adapter *adapter, int cmd, if (!dmadata) return -ENOMEM; + if (READ_ONCE(dev->disconnected)) { + kfree(dmadata); + return -ENODEV; + } + /* do control transfer */ ret = usb_control_msg(dev->usb_dev, usb_sndctrlpipe(dev->usb_dev, 0), cmd, USB_TYPE_VENDOR | USB_RECIP_INTERFACE, @@ -219,6 +232,15 @@ static void i2c_tiny_usb_free(struct i2c_tiny_usb *dev) kfree(dev); } +static void i2c_tiny_usb_release(struct work_struct *work) +{ + struct i2c_tiny_usb *dev = container_of(work, struct i2c_tiny_usb, + release_work); + + i2c_del_adapter(&dev->adapter); + i2c_tiny_usb_free(dev); +} + static int i2c_tiny_usb_probe(struct usb_interface *interface, const struct usb_device_id *id) { @@ -268,6 +290,8 @@ static int i2c_tiny_usb_probe(struct usb_interface *interface, dev->adapter.dev.parent = &dev->interface->dev; + INIT_WORK(&dev->release_work, i2c_tiny_usb_release); + /* and finally attach to i2c layer */ i2c_add_adapter(&dev->adapter); @@ -287,9 +311,9 @@ static void i2c_tiny_usb_disconnect(struct usb_interface *interface) { struct i2c_tiny_usb *dev = usb_get_intfdata(interface); - i2c_del_adapter(&dev->adapter); usb_set_intfdata(interface, NULL); - i2c_tiny_usb_free(dev); + WRITE_ONCE(dev->disconnected, true); + queue_work(system_long_wq, &dev->release_work); dev_dbg(&interface->dev, "disconnected\n"); }