From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D672246A06; Wed, 15 Jan 2025 08:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736931534; cv=none; b=gdNr5cO3dVEba85gg5Qc+7Nf8pc7N9U/xwM35b03f53jUmp3gQE9K2sD2QhVzyhg98wh6H+FBVxQ3beEf0qAkN0qnmk0ikllPYjJOoapURnEWHRdVldmCa1XZ0lH1fwfT0/1iur9MkneA7QI4hmOT9+TWj2z3qGtdWLY3F/BnIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736931534; c=relaxed/simple; bh=vI6Xwhvptn1zlvH6NJeG2RVQFhP751RykEiTaO65sxM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=mkLcCiN+XaQgHvDdD0W+bm47KmSxcPKpY02UwBThuUjILjgEkB/Dquh+M6E8N3MNqff2TmtdSqqnih875Q0CyqSm56HW5RHtivqsTrz9NhQV4oW4Xsg+U4I149U2+KZqR3hO1q7vL18RInIUt4hhJd8zQuvvIjkR12lhlx1cBkU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dhqVzbb1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dhqVzbb1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A94D2C4CEE1; Wed, 15 Jan 2025 08:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736931533; bh=vI6Xwhvptn1zlvH6NJeG2RVQFhP751RykEiTaO65sxM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dhqVzbb1B+OzzHH3tYcq27OtXwx3B8QUMRaVh7eMTaHQmCLYDZ8dNqqiNj6BXCxNo Cij4B3TpjBMH137MMS/VkjM8jhuE39hz1Ez9BIz+VjgDMwEuJ8Bf2dwbAIPw27QJQj b3OnQbxlQU4b5+zpEvhIYr8MdGmK9g6Gx+8IxTW+JCm+uAo87+eGvqEyKWLd7Tyb06 i77XWUK3y6NVbctrB/iiyV7Ov379qzGBlfSIlkCadz2oZ2l9FEQ/rYc6e/Z1E2Q5qc ekHRD8Bvr2DA44oRnNP6Z2z1gdNUEZTCUKMj2K5Y1EjWAkqVzFDxQDuyXOGHa36GuI brV0E6djZUfTg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXzEg-00CPh3-Pf; Wed, 15 Jan 2025 08:58:51 +0000 Date: Wed, 15 Jan 2025 08:58:50 +0000 Message-ID: <86bjw8wj05.wl-maz@kernel.org> From: Marc Zyngier To: Bjorn Helgaas Cc: Frank Li , Bjorn Helgaas , Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?UTF-8?B?V2lsY3p5?= =?UTF-8?B?xYRza2k=?= , Manivannan Sadhasivam , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, alyssa@rosenzweig.io, bpf@vger.kernel.org, broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org, lgirdwood@gmail.com, p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org Subject: Re: [PATCH v9 0/2] PCI: add enabe(disable)_device() hook for bridge In-Reply-To: <20250114223341.GA495433@bhelgaas> References: <20250114-imx95_lut-v9-0-39f58dbed03a@nxp.com> <20250114223341.GA495433@bhelgaas> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: helgaas@kernel.org, Frank.Li@nxp.com, bhelgaas@google.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, alyssa@rosenzweig.io, bpf@vger.kernel.org, broonie@kernel.org, jgg@ziepe.ca, joro@8bytes.org, lgirdwood@gmail.com, p.zabel@pengutronix.de, robin.murphy@arm.com, will@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 14 Jan 2025 22:33:41 +0000, Bjorn Helgaas wrote: >=20 > On Tue, Jan 14, 2025 at 03:37:07PM -0500, Frank Li wrote: > > Some system's IOMMU stream(master) ID bits(such as 6bits) less than > > pci_device_id (16bit). It needs add hardware configuration to enable > > pci_device_id to stream ID convert. > >=20 > > https://lore.kernel.org/imx/20240622173849.GA1432357@bhelgaas/ > > This ways use pcie bus notifier (like apple pci controller), when new P= CIe > > device added, bus notifier will call register specific callback to hand= le > > look up table (LUT) configuration. > >=20 > > https://lore.kernel.org/imx/20240429150842.GC1709920-robh@kernel.org/ > > which parse dt's 'msi-map' and 'iommu-map' property to static config LUT > > table (qcom use this way). This way is rejected by DT maintainer Rob. > >=20 > > Above ways can resolve LUT take or stream id out of usage the problem. = If > > there are not enough stream id resource, not error return, EP hardware > > still issue DMA to do transfer, which may transfer to wrong possition. > >=20 > > Add enable(disable)_device() hook for bridge can return error when not > > enough resource, and PCI device can't enabled. > >=20 > > Basicallly this version can match Bjorn's requirement: > > 1: simple, because it is rare that there are no LUT resource. > > 2: EP driver probe failure when no LUT, but lspci can see such device. > >=20 > > [ 2.164415] nvme nvme0: pci function 0000:01:00.0 > > [ 2.169142] pci 0000:00:00.0: Error enabling bridge (-1), continuing > > [ 2.175654] nvme 0000:01:00.0: probe with driver nvme failed with er= ror -12 > >=20 > > > lspci > > 0000:00:00.0 PCI bridge: Philips Semiconductors Device 0000 > > 0000:01:00.0 Non-Volatile memory controller: Micron Technology Inc 2100= AI NVMe SSD [Nitro] (rev 03) > >=20 > > To: Bjorn Helgaas > > To: Richard Zhu > > To: Lucas Stach > > To: Lorenzo Pieralisi > > To: Krzysztof Wilczy=C5=84ski > > To: Manivannan Sadhasivam > > To: Rob Herring > > To: Shawn Guo > > To: Sascha Hauer > > To: Pengutronix Kernel Team > > To: Fabio Estevam > > Cc: linux-pci@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: imx@lists.linux.dev > > Cc: Frank.li@nxp.com \ > > Cc: alyssa@rosenzweig.io \ > > Cc: bpf@vger.kernel.org \ > > Cc: broonie@kernel.org \ > > Cc: jgg@ziepe.ca \ > > Cc: joro@8bytes.org \ > > Cc: l.stach@pengutronix.de \ > > Cc: lgirdwood@gmail.com \ > > Cc: maz@kernel.org \ > > Cc: p.zabel@pengutronix.de \ > > Cc: robin.murphy@arm.com \ > > Cc: will@kernel.org \ > > Cc: Robin Murphy > > Cc: Marc Zyngier > >=20 > > Signed-off-by: Frank Li >=20 > Applied to pci/controller/imx6 for v6.14, thanks! And thanks for your > patience. While you're at it, could you please consider [1], which builds on top of the same infrastructure to remove the Apple PCIe IOMMU hack? Thanks, M. [1] https://lore.kernel.org/linux-pci/20241204150145.800408-1-maz@kernel.or= g/ --=20 Without deviation from the norm, progress is not possible.