From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DD1C49ED6 for ; Wed, 11 Sep 2019 14:18:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C81AE21928 for ; Wed, 11 Sep 2019 14:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1568211518; bh=MPYXHF4NFDxzN64fMN3pv+7iLSUKDgWE4qLRbssKPtk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=tGQaFprRs4DR9niGkp/GIsFC3WdEjiQl1FROp8dYyb8UjXylO33aIWwlhRmVUxET/ umHRLMNwfwl0UgvI2gkXd20A8Y1lNN8/lMYhmKpwB8oz4UvAggh2C2qb7bLGfA0wEj tT7rAabpuv3EzAmmUlheEovryNRgvu6yTHCsv8bY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbfIKOSi (ORCPT ); Wed, 11 Sep 2019 10:18:38 -0400 Received: from foss.arm.com ([217.140.110.172]:48390 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725981AbfIKOSh (ORCPT ); Wed, 11 Sep 2019 10:18:37 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FE671000; Wed, 11 Sep 2019 07:18:37 -0700 (PDT) Received: from big-swifty.misterjones.org (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EFAE3F67D; Wed, 11 Sep 2019 07:18:33 -0700 (PDT) Date: Wed, 11 Sep 2019 15:18:31 +0100 Message-ID: <86blvqsyq0.wl-maz@kernel.org> From: Marc Zyngier To: Talel Shenhar Cc: , , , , , , , , , , , Subject: Re: [PATCH v2 3/3] soc: amazon: al-pos: cast to u64 before left shifting In-Reply-To: <1568142310-17622-4-git-send-email-talel@amazon.com> References: <1568142310-17622-1-git-send-email-talel@amazon.com> <1568142310-17622-4-git-send-email-talel@amazon.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Sep 2019 20:05:10 +0100, Talel Shenhar wrote: > > Fix wrap around for pos errors on addresses above 32 bit. > > Reported-by: kbuild test robot > Signed-off-by: Talel Shenhar > --- > drivers/soc/amazon/al_pos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/amazon/al_pos.c b/drivers/soc/amazon/al_pos.c > index a865111..e95e1fc 100644 > --- a/drivers/soc/amazon/al_pos.c > +++ b/drivers/soc/amazon/al_pos.c > @@ -49,7 +49,7 @@ static irqreturn_t al_pos_irq_handler(int irq, void *info) > writel(0, pos->mmio_base + AL_POS_ERROR_LOG_1); > > addr = FIELD_GET(AL_POS_ERROR_LOG_0_ADDR_LOW, log0); > - addr |= (FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1) << 32); > + addr |= (((u64)FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1)) << 32); > request_id = FIELD_GET(AL_POS_ERROR_LOG_1_REQUEST_ID, log1); > bresp = FIELD_GET(AL_POS_ERROR_LOG_1_BRESP, log1); > > -- > 2.7.4 > This fix should be squashed into the previous patch. Thanks, M. -- Jazz is not dead, it just smells funny.