From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753282AbaEWMxg (ORCPT ); Fri, 23 May 2014 08:53:36 -0400 Received: from void.printf.net ([89.145.121.20]:36428 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232AbaEWMxd (ORCPT ); Fri, 23 May 2014 08:53:33 -0400 From: Chris Ball To: Ulf Hansson Cc: Andrew Bresticker , Stephen Warren , Thierry Reding , linux-mmc , "linux-tegra\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-arm-kernel\@lists.infradead.org" Subject: Re: [PATCH v3 2/2] mmc: tegra: fix reporting of base clock frequency References: <1400774136-12396-1-git-send-email-abrestic@chromium.org> <1400774136-12396-2-git-send-email-abrestic@chromium.org> Date: Fri, 23 May 2014 13:53:29 +0100 In-Reply-To: (Ulf Hansson's message of "Fri, 23 May 2014 09:04:12 +0200") Message-ID: <86bnuor706.fsf@void.printf.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, May 23 2014, Ulf Hansson wrote: > On 22 May 2014 17:55, Andrew Bresticker wrote: >> Tegra SDHCI controllers, by default, report a base clock frequency >> of 208Mhz in SDHCI_CAPABILTIES which may or may not be equal to the >> actual base clock frequency. This is because the clock rate is >> configured by the clock controller, which is external to the SD/MMC >> controller. Since the SD/MMC controller has no knowledge of how this >> clock is configured, it will simply report the maximum frequency. >> While the reported value can be overridden by setting BASE_CLK_FREQ in >> VENDOR_CLOCK_CTRL on Tegra30 and later SoCs, just set CAP_CLOCK_BASE_BROKEN >> and supply sdhci_pltfm_clk_get_max_clock(), which simply does a >> clk_get_rate(), as the get_max_clock() callback. >> >> Signed-off-by: Andrew Bresticker >> Tested-by: Stephen Warren >> Acked-by: Stephen Warren > > Thanks Andrew! > > Signed-off-by: Ulf Hansson > > Chris, can you pick this up? Thanks, pushed to mmc-next for 3.16. - Chris. -- Chris Ball