Re: [PATCH] show_task() and thread_saved_pc() fix for x86

[Jean Wolter <jean.wolter@inf.tu-dresden.de>]

Richard Henderson <rth@twiddle.net> writes:

> > OTOH, the value is used only by Alt-SysRq-T, so... Hell knows.
> 
> No, it's also used by 'ps -l'.  See wchan.

ps -l uses get_wchan() (an architecture specific function from
arch/*/kernel/process.c) to get the return address from
schedule(). And now thread_saved_pc() seems to do the same (at least
on x86). Is there any reason to have two architecture specific
functions doing the same or do I miss something?

Jean

PS: Architectures other then x86 use thread_saved_pc() to implement
get_wchan(). If the debug output of Alt-SysRq-T is supposed to show
the waiting channel we should use get_wchan() instead of thread_saved_pc().
-- 
I get up each morning, gather my wits.
Pick up the paper, read the obits.
if I'm not there I know I'm not dead.
So I eat a good breakfast and go back to bed. Peete Seeger
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/