From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 14 Nov 2000 04:50:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 14 Nov 2000 04:50:42 -0500 Received: from kurt.inf.tu-dresden.de ([141.76.48.99]:12773 "EHLO kurt.inf.tu-dresden.de") by vger.kernel.org with ESMTP id ; Tue, 14 Nov 2000 04:50:24 -0500 From: Jean Wolter Organisation: Dresden University of Technology To: Richard Henderson Cc: Alexander Viro , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [PATCH] show_task() and thread_saved_pc() fix for x86 In-Reply-To: <20001113175017.B1820@twiddle.net> Mime-Version: 1.0 (generated by tm-edit 1.5) Content-Type: text/plain; charset=US-ASCII Date: 14 Nov 2000 10:19:32 +0100 In-Reply-To: Richard Henderson's message of "Mon, 13 Nov 2000 17:50:17 -0800" Message-ID: <86bsvizza3.fsf@kurt.inf.tu-dresden.de> X-Mailer: Gnus v5.6.45/XEmacs 21.1 - "Carlsbad Caverns" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Richard Henderson writes: > > OTOH, the value is used only by Alt-SysRq-T, so... Hell knows. > > No, it's also used by 'ps -l'. See wchan. ps -l uses get_wchan() (an architecture specific function from arch/*/kernel/process.c) to get the return address from schedule(). And now thread_saved_pc() seems to do the same (at least on x86). Is there any reason to have two architecture specific functions doing the same or do I miss something? Jean PS: Architectures other then x86 use thread_saved_pc() to implement get_wchan(). If the debug output of Alt-SysRq-T is supposed to show the waiting channel we should use get_wchan() instead of thread_saved_pc(). -- I get up each morning, gather my wits. Pick up the paper, read the obits. if I'm not there I know I'm not dead. So I eat a good breakfast and go back to bed. Peete Seeger - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/