From: Marc Zyngier <maz@kernel.org>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Qiang Yu <qiang.yu@oss.qualcomm.com>,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: MSIs not freed in GICv3 ITS driver
Date: Mon, 30 Mar 2026 09:17:10 +0100 [thread overview]
Message-ID: <86cy0l4tq1.wl-maz@kernel.org> (raw)
In-Reply-To: <ecou7yeb3bpzsz3tgzubotx5wym6zo7h2bzwvoo7zqppzcv2hj@mowg4zesjhsv>
On Tue, 03 Mar 2026 09:26:32 +0000,
Manivannan Sadhasivam <mani@kernel.org> wrote:
>
> The above issue should be applicable to other MSI controller drivers as well,
> not just DWC.
The core issue is not with the irqchips, but with the MSI subsystem.
Multi-MSI devices should always result in a strict power-of-2
allocation, because that's all the HW supports. Yet, we let drivers
request a stupid number of interrupts.
I can see two outcomes: either we force the allocation to the next 2^
value, or we return an error to the caller. The first one costs memory
(extra irq descriptors), the latter forces people to fix their crap.
I'm tempted to propose the latter.
M.
--
Without deviation from the norm, progress is not possible.
prev parent reply other threads:[~2026-03-30 8:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 15:39 MSIs not freed in GICv3 ITS driver Manivannan Sadhasivam
2024-07-08 17:31 ` Marc Zyngier
2024-07-09 17:37 ` Manivannan Sadhasivam
2024-07-09 19:24 ` Marc Zyngier
2024-07-21 8:50 ` Manivannan Sadhasivam
2026-01-16 15:03 ` Manivannan Sadhasivam
2026-02-19 16:54 ` Marc Zyngier
2026-02-25 9:34 ` Qiang Yu
2026-02-26 13:39 ` Marc Zyngier
2026-03-03 5:22 ` Qiang Yu
2026-03-03 9:26 ` Manivannan Sadhasivam
2026-03-30 8:17 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86cy0l4tq1.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=qiang.yu@oss.qualcomm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox