From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF6A8157E61; Tue, 23 Jul 2024 17:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721754277; cv=none; b=oKoBvjxcljIxptTSPvJlECzvFYbB1B6an2yB7hE64cy5Mm9tc+xQqIt9wKAondWTNLv9qcdmLY/BZwSm9qBT4Lf46kUFoYu/pLWNSz/p+SOfDpsk4BfbIahrTz8vflBNhdYYoZvMIGZ9ZUnz5D68lnqwnyAaBiEmuHq7JXm7NFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721754277; c=relaxed/simple; bh=MxN/WLnGKf7av7xKNhhUY8LWbs931XIEUtFb3naxcy8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=Lr4U7dp0U2t4huiOJjbmHUZFySYBv1cUGq4jyHFNCFS5a5lGgL+acvOU2iWK6B2GOYw3WwBTkUmdfgrF/e6EdGG/vP85dvmf2O8R51fuxKxDYfOB+LKl+j0KEupgHmlkWUbzB1NOXvhnKmIsUD/sCSYsM/N2dGcX0kHb3EyDHJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uj7m7qOu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uj7m7qOu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAC6AC4AF0C; Tue, 23 Jul 2024 17:04:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721754276; bh=MxN/WLnGKf7av7xKNhhUY8LWbs931XIEUtFb3naxcy8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uj7m7qOu4xOj8Dmv+70XOg6djEehnR/RzmwEBzrwoNA3f+V/k4hNZZMENVxjd5PyE EeshgK0umyb1rblPa5oL9TiUoo//GKKSmqZTlgiJfWm5Vw3ZhBbNZidjweLwQYXnoL F/UidCtbQHgbMsjqvCClQrl7lrZZNXImAL6VPiXz8MvZfrI8P0gmMgYkUVxKIoOhu5 4CKcjbJMXhThtVUVyEg2l/9RkdWcHbiYPmI6QPILgLuF39WWNQG70ovt6m+kjoqENw aPjvtHxY232ky5BOkqa7JxXrrArZdAnV08N7gRKlAkDk8m10C2fsfVeAa/8pyTsnY9 hdzPHX8HKXbjg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sWIwE-00Emgx-Bf; Tue, 23 Jul 2024 18:04:34 +0100 Date: Tue, 23 Jul 2024 18:04:34 +0100 Message-ID: <86cyn42g65.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Ott Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Zenghui Yu , Mark Rutland Subject: Re: [PATCH v2 0/3] KVM: arm64: fix warnings in W=1 build In-Reply-To: <20240723101204.7356-1-sebott@redhat.com> References: <20240723101204.7356-1-sebott@redhat.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebott@redhat.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, yuzenghui@huawei.com, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 23 Jul 2024 11:12:01 +0100, Sebastian Ott wrote: > > Building arch/arm64/kvm/ with W=1 spills out a lot of warnings. When > changing stuff I try to use as much tooling as possible to make sure > that I don't screw up - having a clean baseline imho helps with that. > > With the first 2 patches applied make W=1 arch/arm64/kvm/ runs without > warnings for me (fedora userspace, upstream linux after kvm merge). > Patch 3 gets rid of sparse lock warnings in arch/arm64/kvm/vgic/. > > Patch 1 now just adds -Wno-override-init to the cflags of the affected > files. Alternatives would be to add this to the whole subdir or > reintroduce the flag for higher warn levels.. > > Sebastian Ott (3): > KVM: arm64: fix override-init warnings in W=1 builds > KVM: arm64: fix kdoc warnings in W=1 builds > KVM: arm64: vgic: fix unexpected unlock sparse warnings > > arch/arm64/kvm/Makefile | 3 +++ > arch/arm64/kvm/arm.c | 1 + > arch/arm64/kvm/hyp/nvhe/Makefile | 2 ++ > arch/arm64/kvm/hyp/vhe/Makefile | 2 ++ > arch/arm64/kvm/vgic/vgic-irqfd.c | 7 ++++--- > arch/arm64/kvm/vgic/vgic-its.c | 18 +++++++++++------- > arch/arm64/kvm/vgic/vgic-v3.c | 2 +- > arch/arm64/kvm/vgic/vgic.c | 2 +- > arch/arm64/kvm/vgic/vgic.h | 2 +- > 9 files changed, 26 insertions(+), 13 deletions(-) For the series, and assuming we take this in 6.11:: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.