From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbdLFSk7 (ORCPT ); Wed, 6 Dec 2017 13:40:59 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:24116 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbdLFSk4 (ORCPT ); Wed, 6 Dec 2017 13:40:56 -0500 Subject: Re: [PATCH v2 09/19] ASoC: tlv320aic31xx: Remove platform data To: Mark Brown CC: Liam Girdwood , Rob Herring , Mark Rutland , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , , , References: <20171129213300.20021-1-afd@ti.com> <20171129213300.20021-10-afd@ti.com> <20171201132606.vyw7wthmql5trkwq@sirena.org.uk> <4fee76ef-e518-69b6-3bcc-f65b0a31cacc@ti.com> <20171206124540.GC1827@finisterre> <10f1b19b-4a0a-e336-b757-933d46b5c8e9@ti.com> <20171206173059.qw4tt7nizmyo6xbl@sirena.org.uk> <20171206181534.7t23ljja6fgle4ar@sirena.org.uk> From: "Andrew F. Davis" Message-ID: <86e13e26-e8d5-35ed-6bd0-d91d9323d5e6@ti.com> Date: Wed, 6 Dec 2017 12:40:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171206181534.7t23ljja6fgle4ar@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2017 12:15 PM, Mark Brown wrote: > On Wed, Dec 06, 2017 at 11:48:43AM -0600, Andrew F. Davis wrote: > >> That would be unreasonable I agree, but it's also completely >> hypothetical, as again, there are no in-tree users and most platforms >> are DT/ACPI, so the odds of anyone needing it are next to nothing. > > You're removing support for something someone might want to use for no > clear gain. The bar for doing that needs to be higher than just random > cleanup, it needs to actively bring some benefit that justifies the > cost. If something is sitting there not getting in the way and is > potentially going to be helpful for something in the future then there > needs to be a positive reason to take it away. > For some userspace feature sure, but this is kernel code, there is no guarantee for a sable API, in fact some would probably argue even further that there is a guarantee that stuff *will* change and this is a good thing as it kinda serves to punish for those you don't try to upstream. So the helpfulness bar should be zero for changes that break out-of-tree stuff. Even more so this patch isn't a zero gain, the cleaner, better looking, and easier to maintain code *is* the benefit in itself. Plus we gain the ability to set mic-gain voltage with ACPI, something you couldn't do before this patch.