From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Yury Norov <ynorov@nvidia.com>
Cc: Thomas Gleixner <tglx@kernel.org>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Alice Ryhl <aliceryhl@google.com>,
Viktor Malik <vmalik@redhat.com>,
Randy Dunlap <rdunlap@infradead.org>,
David Laight <david.laight.linux@gmail.com>,
linux-kernel@vger.kernel.org, Yury Norov <yury.norov@gmail.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 0/3] uaccess: unify inline vs outline copy_{from,to}_user() selection
Date: Mon, 27 Apr 2026 20:47:49 +0200 [thread overview]
Message-ID: <86e9faec-06be-4e37-a07d-7cd3df3c4006@kernel.org> (raw)
In-Reply-To: <20260427085814.7ca0b134603b8d5813e23396@linux-foundation.org>
Le 27/04/2026 à 17:58, Andrew Morton a écrit :
> On Fri, 24 Apr 2026 22:08:54 -0400 Yury Norov <ynorov@nvidia.com> wrote:
>
>> The kernel allows arches to select between inline and outline
>> implementations of the copy_{from,to}_user() by defining individual
>> INLINE_COPY_FROM_USER and INLINE_COPY_TO_USER, correspondingly.
>> However, all arches enable or disable them always together.
>>
>> Without the real use-case for one helper being inlined while the other
>> outlined, having independent controls is excessive and error prone.
>>
>> The first patch of the series fixes rust/uaccess coppy_to_user() wrapper
>> guarded with INLINE_COPY_FROM_USER. The 2nd patch switches codebase to
>> the unified INLINE_COPY_USER. And the last patch cleans up ifdefery in
>> the include/linux/uaccess.h
>
> Seems sensible, thanks. I'll queue these up for test-n-review.
>
> Arnd was involved in some of the Fixes: commits and might be interested
> in these changes, so Cc:.
>
I have an alternative as patch 2 in this series :
https://lore.kernel.org/all/cover.1777306795.git.chleroy@kernel.org/
Christophe
prev parent reply other threads:[~2026-04-27 18:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 2:08 [PATCH v2 0/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-04-25 2:08 ` [PATCH v2 1/3] rust: uaccess: use INLINE_COPY_TO_USER to guard copy_to_user() Yury Norov
2026-04-27 14:54 ` [PATCH v2 1/3] rust: uaccess: use INLINE_COPY_TO_USER to guard copy_to_user()\ Alice Ryhl
2026-04-25 2:08 ` [PATCH v2 2/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Yury Norov
2026-04-25 2:08 ` [PATCH v2 3/3] uaccess: minimize INLINE_COPY_USER-related ifdefery Yury Norov
2026-04-27 15:58 ` [PATCH v2 0/3] uaccess: unify inline vs outline copy_{from,to}_user() selection Andrew Morton
2026-04-27 18:47 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86e9faec-06be-4e37-a07d-7cd3df3c4006@kernel.org \
--to=chleroy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=tglx@kernel.org \
--cc=vmalik@redhat.com \
--cc=ynorov@nvidia.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox