From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6591AF4DD; Wed, 21 Aug 2024 13:46:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724247988; cv=none; b=gArLTg0Bx59+FlS3tjtWT9/W8sRvZAIIHCaVqh9kzqIEUaLIK0yXIta2NhFA/oDbDj7pMzORWwh81exhN28+isZk2P9Zvrqy//qyy9nk6jzggvFErN9wNfE2/kfHP9/iFxIHRF6i+6KgvXgwEhr2JClt+KRmxNifGzO6amYhGqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724247988; c=relaxed/simple; bh=K0I2LmOVKPqYuEGAfHzeGjhEUY2uSjqj5ZyhfoHUFYc=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=uQLcwIgGNbXJPGsQmpsYKPqOOz9d7a5cBxU08lGzUUo0UfUhK61IKQKRaSGNtwZrHW5+e3L7GdaOf3o3kEjzYt8LtKIibYBvcT4DozRi1vSAjD2rNrqckVJlXy6h9dnS3ZL6eybhsV7BIMqhySG8XQ9Ka8uf/uTgaRBE8EZNEJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MlnlOxR8; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MlnlOxR8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD5DFC32782; Wed, 21 Aug 2024 13:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724247987; bh=K0I2LmOVKPqYuEGAfHzeGjhEUY2uSjqj5ZyhfoHUFYc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MlnlOxR8cd8v8rtNwSSX3AYvxy6PwEZqIDw4TmYOm/qy1zenQIrymaXakByyNnNiJ KZsCScFhXklkoCu2lSbhsl37lWRwH7Q9pPI53Ll55vQK99v0jvetw6VE55jMDBcXRW s3Bgek9TO4ffKlANwN+rpfRdY5s1mxUKNOta3q5J0gI/o5uGB4Z1+qFBP+8/Tnx92O nNhR378CYR03uBOXcwzqPhVGK7V4C2KooqZJbyzINHijyN2gr9KWX/U8tjQz493u3X yR/ToXSNWI8adG1SPXpeOV5glEnwMVQb/La0rxZrk1LGSQ+JiXKqVAwfcF+tw03kIT ghVoaloQPXOgQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sglfN-005bo9-TJ; Wed, 21 Aug 2024 14:46:25 +0100 Date: Wed, 21 Aug 2024 14:46:25 +0100 Message-ID: <86ed6ixa32.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Joey Gouly , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] KVM: arm64: Control visibility of S1PIE related sysregs to userspace In-Reply-To: <20240821-kvm-arm64-hide-pie-regs-v1-0-08cb3c79cb57@kernel.org> References: <20240821-kvm-arm64-hide-pie-regs-v1-0-08cb3c79cb57@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 21 Aug 2024 14:07:14 +0100, Mark Brown wrote: > > While looking at the KVM system register code I noticed that we do not > have visibility operations for TCR2 or the S1PIE registers, I may be > missing some reason why they are not required but in case I'm not I > figured the most direct way to ask was to propose adding the operations. > > Signed-off-by: Mark Brown > --- > Mark Brown (2): > KVM: arm64: Hide TCR2_EL1 from userspace when disabled for guests > KVM: arm64: Hide S1PIE registers from userspace when disabled for guests > > arch/arm64/include/asm/kvm_host.h | 6 ++++++ > arch/arm64/kvm/sys_regs.c | 31 ++++++++++++++++++++++++++----- > 2 files changed, 32 insertions(+), 5 deletions(-) If you are going to do this, please add it on top of [1], and handle the corresponding EL2 registers. Thanks, M. [1] https://lore.kernel.org/20240813144738.2048302-1-maz@kernel.org -- Without deviation from the norm, progress is not possible.