From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F330C154BE8; Tue, 23 Jul 2024 15:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721746808; cv=none; b=u1+ZdlSIP5bcCm5mK0Ks7oL3NM0U0Ecbaa9JvLEx1H+cJxMB5QPyiQ0gDxHvaWElQNL6m8pgZQchi7YDSeGa+p2g0r5RSH53TvYcdhGSotVbktW+O4VnZiX4K8QOkiICa6kDLBhkQT8VxnBvjnOtIqGypufw4jczss7iqEchxTU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721746808; c=relaxed/simple; bh=4DA2XWj/UrCTxITuQswP8CQ61smzRnN3hRrP34Z4cjY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=SlkXdCaL7wTAfCUHQSJU3qMjdxSazP33ISmw/3hLUWUYsPHO52IOypLISR5VIqoYOlEMUD6VLSWRZThUcmEaBbX0AjtSRAg3wr1avQVbXtetK2ksLcH7lmlGuwwmUGba5cuv/1HZvlAtO8EPGI6Hcx0NVggQw97XM+HIqRJi0SQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DS8tyUU7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DS8tyUU7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 807DCC4AF0A; Tue, 23 Jul 2024 15:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721746807; bh=4DA2XWj/UrCTxITuQswP8CQ61smzRnN3hRrP34Z4cjY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DS8tyUU7ud8/42wIElau7PNvNstxx1rBpQJsMWYVk7f2lSjpmVbhmFHPe9+c9hfpk VBgE9UrvxsFvKSDG48exXBpp+gG0xG3iIqp8BeUD5EMT5Bv0JGKtL/K6V25AlRdK4h Q3P1v6REJ9KW1lClfN4IWnqikeciltd3NRDbMjJ8XsGBBmtWdB8OHGjBXeMvbW8KuN cn1UX3iiCtpCunQS1t0Wru+kjo3MnEzmyIDzLgwvaEZRoJFXe9F4OpviPJ3IfEgS5J Go1GsLGygzVNXIXo5qbEXwbKxWmLDnSFoU2Tzfm6McroBfpgC9mvo2lE2ZYhM7kQ8l ViH3XDspvDiQw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sWGzl-00Ekd3-3P; Tue, 23 Jul 2024 16:00:05 +0100 Date: Tue, 23 Jul 2024 16:00:04 +0100 Message-ID: <86ed7k2lxn.wl-maz@kernel.org> From: Marc Zyngier To: Danilo Krummrich Cc: oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: free kvm->arch.nested_mmus with kvfree() In-Reply-To: <20240723142204.758796-1-dakr@kernel.org> References: <20240723142204.758796-1-dakr@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dakr@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, christoffer.dall@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 23 Jul 2024 15:20:52 +0100, Danilo Krummrich wrote: > > kvm->arch.nested_mmus is allocated with kvrealloc(), hence free it with > kvfree() instead of kfree(). > > Fixes: 4f128f8e1aaa ("KVM: arm64: nv: Support multiple nested Stage-2 mmu structures") > Signed-off-by: Danilo Krummrich > --- > arch/arm64/kvm/nested.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c > index de789e0f1ae9..bab27f9d8cc6 100644 > --- a/arch/arm64/kvm/nested.c > +++ b/arch/arm64/kvm/nested.c > @@ -786,7 +786,7 @@ void kvm_arch_flush_shadow_all(struct kvm *kvm) > if (!WARN_ON(atomic_read(&mmu->refcnt))) > kvm_free_stage2_pgd(mmu); > } > - kfree(kvm->arch.nested_mmus); > + kvfree(kvm->arch.nested_mmus); > kvm->arch.nested_mmus = NULL; > kvm->arch.nested_mmus_size = 0; > kvm_uninit_stage2_mmu(kvm); > Ah, nice catch. Thanks for fixing it. Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.