[tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

[tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

[tip-bot2 for Marc Zyngier]

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     daa19fe5b082779962988a5ba9e38509004db3de
Gitweb:        https://git.kernel.org/tip/daa19fe5b082779962988a5ba9e38509004db3de
Author:        Marc Zyngier <maz@kernel.org>
AuthorDate:    Wed, 31 Jul 2019 16:13:42 +01:00
Committer:     Marc Zyngier <maz@kernel.org>
CommitterDate: Wed, 07 Aug 2019 14:24:45 +01:00

gpio/ixp4xx: Register the base PA instead of its VA in fwnode

Do not expose the base VA (it appears in debugfs). Instead,
record the PA, which at least can be used to precisely identify
the associated irqchip and domain.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
 drivers/gpio/gpio-ixp4xx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-ixp4xx.c b/drivers/gpio/gpio-ixp4xx.c
index 670c2a8..cc72c9a 100644
--- a/drivers/gpio/gpio-ixp4xx.c
+++ b/drivers/gpio/gpio-ixp4xx.c
@@ -400,7 +400,7 @@ static int ixp4xx_gpio_probe(struct platform_device *pdev)
 		g->fwnode = of_node_to_fwnode(np);
 	} else {
 		parent = ixp4xx_get_irq_domain();
-		g->fwnode = irq_domain_alloc_fwnode(g->base);
+		g->fwnode = irq_domain_alloc_fwnode(&res->start);
 		if (!g->fwnode) {
 			dev_err(dev, "no domain base\n");
 			return -ENODEV;

Re: [tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

[Linus Walleij]

On Fri, Sep 6, 2019 at 12:08 PM tip-bot2 for Marc Zyngier
<tip-bot2@linutronix.de> wrote:

> The following commit has been merged into the irq/core branch of tip:
>
> Commit-ID:     daa19fe5b082779962988a5ba9e38509004db3de
> Gitweb:        https://git.kernel.org/tip/daa19fe5b082779962988a5ba9e38509004db3de
> Author:        Marc Zyngier <maz@kernel.org>
> AuthorDate:    Wed, 31 Jul 2019 16:13:42 +01:00
> Committer:     Marc Zyngier <maz@kernel.org>
> CommitterDate: Wed, 07 Aug 2019 14:24:45 +01:00
>
> gpio/ixp4xx: Register the base PA instead of its VA in fwnode
>
> Do not expose the base VA (it appears in debugfs). Instead,
> record the PA, which at least can be used to precisely identify
> the associated irqchip and domain.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Marc Zyngier <maz@kernel.org>

I think that patch is already in my gpio devel branch.

But I guess it doesn't hurt either, git will figure it out.

Yours,
Linus Walleij

Re: [tip: irq/core] gpio/ixp4xx: Register the base PA instead of its VA in fwnode

[Marc Zyngier]

On Sun, 08 Sep 2019 09:09:47 +0100,
Linus Walleij <linus.walleij@linaro.org> wrote:
> 
> On Fri, Sep 6, 2019 at 12:08 PM tip-bot2 for Marc Zyngier
> <tip-bot2@linutronix.de> wrote:
> 
> > The following commit has been merged into the irq/core branch of tip:
> >
> > Commit-ID:     daa19fe5b082779962988a5ba9e38509004db3de
> > Gitweb:        https://git.kernel.org/tip/daa19fe5b082779962988a5ba9e38509004db3de
> > Author:        Marc Zyngier <maz@kernel.org>
> > AuthorDate:    Wed, 31 Jul 2019 16:13:42 +01:00
> > Committer:     Marc Zyngier <maz@kernel.org>
> > CommitterDate: Wed, 07 Aug 2019 14:24:45 +01:00
> >
> > gpio/ixp4xx: Register the base PA instead of its VA in fwnode
> >
> > Do not expose the base VA (it appears in debugfs). Instead,
> > record the PA, which at least can be used to precisely identify
> > the associated irqchip and domain.
> >
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> 
> I think that patch is already in my gpio devel branch.
> 
> But I guess it doesn't hurt either, git will figure it out.

Ah, I'm just a moron. I forgot to drop it after we agreed you would
take it. Yes, git will figure it out, and your branch has the conflict
resolution anyway...

Sorry for dropping the ball on that.

	M.

-- 
Jazz is not dead, it just smells funny.