From: Dmitry Osipenko <digetx@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Mikko Perttunen <cyndis@kapsi.fi>,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 4/8] i2c: tegra: Support atomic transfers
Date: Tue, 14 Jan 2020 01:52:12 +0300 [thread overview]
Message-ID: <86f71bfe-7d17-0bf4-edda-13c84301a598@gmail.com> (raw)
In-Reply-To: <20200113220315.GB2689@ninjato>
14.01.2020 01:03, Wolfram Sang пишет:
> On Sun, Jan 12, 2020 at 08:14:26PM +0300, Dmitry Osipenko wrote:
>> System shutdown may happen with interrupts being disabled and in this case
>> I2C core rejects transfers if atomic transfer isn't supported by driver.
>
> Well, not quite. The core complains about it nowadays, but does not
> reject messages. It will try the same behaviour as before. It will just
> inform the user that somethings is tried which may not work. I probably
> should update the error message printed saying that the transfer is
> still tried.
Indeed, now I'm recalling noticing that the transfer actually should
happen despite of the error message, but then completely forgot to
update the commit's message. I can update the message and send out v5,
if you're thinking that it's worthwhile to do.
>> There were several occurrences where I found my Nexus 7 completely
>> discharged despite of being turned off and then one day I spotted this in
>> the log:
>
> Given my reasoning above, that should have happened before the warning
> was printed as well? Because same behaviour. I'd be surprised if there
> was a change...
Pretty sure that it was happening before, but I wasn't paying much
attention back then.
next prev parent reply other threads:[~2020-01-13 22:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 17:14 [PATCH v4 0/8] NVIDIA Tegra I2C driver fixes and improvements Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 1/8] i2c: tegra: Fix suspending in active runtime PM state Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 2/8] i2c: tegra: Properly disable runtime PM on driver's probe error Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 3/8] i2c: tegra: Prevent interrupt triggering after transfer timeout Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 4/8] i2c: tegra: Support atomic transfers Dmitry Osipenko
2020-01-13 22:03 ` Wolfram Sang
2020-01-13 22:52 ` Dmitry Osipenko [this message]
2020-01-14 1:26 ` Dmitry Osipenko
2020-01-14 5:57 ` Wolfram Sang
2020-01-12 17:14 ` [PATCH v4 5/8] i2c: tegra: Rename I2C_PIO_MODE_MAX_LEN to I2C_PIO_MODE_PREFERRED_LEN Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 6/8] i2c: tegra: Use relaxed versions of readl/writel Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 7/8] i2c: tegra: Always terminate DMA transfer Dmitry Osipenko
2020-01-12 17:14 ` [PATCH v4 8/8] i2c: tegra: Check DMA completion status in addition to left time Dmitry Osipenko
2020-01-13 21:53 ` [PATCH v4 0/8] NVIDIA Tegra I2C driver fixes and improvements Wolfram Sang
2020-01-13 23:01 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86f71bfe-7d17-0bf4-edda-13c84301a598@gmail.com \
--to=digetx@gmail.com \
--cc=cyndis@kapsi.fi \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox