From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E443C8615A; Tue, 14 Jan 2025 14:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866520; cv=none; b=QoC8slvP0PQqt49cTLUjbF0dD1YbZtIRCbboI2KWUrcWR8EVe9UJAl1IBCtsg3CK0gTOI8w8pJZaCpJMcQtI/B/OT4aV+ELbw/YHydsYbr0aN8AcYhwl3I/r6Zrm2T8KrKuCZyFf+4k2zdH/fxf4P1etoGZlXuk8RhdVyteI6DQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736866520; c=relaxed/simple; bh=nQP6jnIHulq6jt5p0Xz5ixFPQLiSyXw6ZYn8aVkEujw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=CU1aGuENlRWoT2VoxwMrddbqX4VlYSKe6Cmj03vA5sbY19wUcY5NQnHPooyC/Es6+3Vi/Fvr5tkt8Qr74kIA0/4oQbes0efpv5mFhOGe2HsFpXma7WFUEZwU5g8DJWxyk+FDvwEBTpbz95+85I4pbUIENlf0ySd3GyxpNE3yyvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X4cfGh7u; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X4cfGh7u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8452C4CEDD; Tue, 14 Jan 2025 14:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736866519; bh=nQP6jnIHulq6jt5p0Xz5ixFPQLiSyXw6ZYn8aVkEujw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=X4cfGh7uKzVZIqlzsaQCwauefqI/qjOKRknrUmbu24GVAtBmuxz2Kjnsgv39HRSmL z+GkgDZfL2pA28a5I1RLwTNqy3QRdpv7scwlat9MFAAf03Hlo7hiXiinkl21yME+FE 53cS7MtEZSOEzVYTmV6u5s/nV0yhnI7nWGsCW42dfY7r8iIe4+wwL4f1dbYUmSS6Rh 5v3r0t4iQs6IyiYTlZVBkPOAFNv13upFHyqwigLzcJ4LQrQETYP7DHUJujkFrVxYt2 btTujYDxoX3I9fFv0+RVKCr/ijcnropjMU3jD4F1YIInWONmLhvryobRN9IX25aqEX oGKqew0WkmoYQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXiK5-00CAZ0-JF; Tue, 14 Jan 2025 14:55:17 +0000 Date: Tue, 14 Jan 2025 14:55:17 +0000 Message-ID: <86frllwilm.wl-maz@kernel.org> From: Marc Zyngier To: Sebastian Ene Cc: catalin.marinas@arm.com, joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com Subject: Re: [PATCH] KVM: arm64: Fix the upper limit of the walker range In-Reply-To: <20250114145050.563658-2-sebastianene@google.com> References: <20250114145050.563658-2-sebastianene@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sebastianene@google.com, catalin.marinas@arm.com, joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 14 Jan 2025 14:50:51 +0000, Sebastian Ene wrote: > > Prevent the walker from running into weeds when walking an > entire address range. > > Signed-off-by: Sebastian Ene > --- > arch/arm64/kvm/hyp/pgtable.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c > index 40bd55966..2ffb5571e 100644 > --- a/arch/arm64/kvm/hyp/pgtable.c > +++ b/arch/arm64/kvm/hyp/pgtable.c > @@ -260,7 +260,7 @@ static int _kvm_pgtable_walk(struct kvm_pgtable *pgt, struct kvm_pgtable_walk_da > { > u32 idx; > int ret = 0; > - u64 limit = BIT(pgt->ia_bits); > + u64 limit = BIT(pgt->ia_bits) - 1; > > if (data->addr > limit || data->end > limit) > return -ERANGE; Huh, nice catch. I guess this deserves a Fixes: b1e57de62cfb4 ("KVM: arm64: Add stand-alone page-table walker infrastructure") Cc: stable@vger.kernel.org right? M. -- Without deviation from the norm, progress is not possible.