From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8AB04CB4E for ; Wed, 3 Apr 2024 06:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712124043; cv=none; b=RRoQyzgPRYhD22fW0Wg4Rj2tQWX8jO3tdYQkhUG0zVY/uX636Z/YNnnE05ulYlGQ/dN5JL0aaE/lOwGheFpvHTh5VeoIMIgxTdQb2SlmiZH06OXQFMdvWc2jqobWSNCj+oOS+0Uptv4kuf8fVKCHxMimQg9qyMeeJ92Fy6ZLwgA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712124043; c=relaxed/simple; bh=lm28SIM4QSvcW8ofLaB3A9XZSPLWwi+KGoQL55Ml0H0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=UG43K7XIR1WUUrJFuMHeY7mAXL79OCvOvlC8M97N3IJqNMAMCYCbYAmG7OCsxOb67UqiDv9B0QYnLEeunJ/jxw/r6Sj9+6wuSCMBoFcRAOlJJo8rMOXi783Y20jwqi3Y4lGyBI7I/o2Y1x82966i1YelIDBTkX9Wcc/GJPQv05U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KH+ZuPuo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KH+ZuPuo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31A2AC433C7; Wed, 3 Apr 2024 06:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712124043; bh=lm28SIM4QSvcW8ofLaB3A9XZSPLWwi+KGoQL55Ml0H0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KH+ZuPuoU4beU30S6hLa4jDXATT7BDGKl00AGr2JavQLUMPAnPjPued78VB9MzuZI zCjca5T7f5LgYWFQ2lQIPZ96OJaF9g7ZtFppclpUr37ICoXlKmO2FODCszTM3NXLyo RE+SCF6S/AzLdjgHB2Anm3sfS18hwQUg6Ze0ZKKbbRw5DEPOkjtTSwmEBZTkT18gj9 BURuikyYRnoIqHUTF4NFbUzZBEgmCwjuHiB8VaZEskLGMOlxX2Q5u318u4YZGHYb/L VrWLbmiz0fZpEz4xHddhairb/jGXs4VOEnZhjcORb4EyVZPI4ZX9xkAooDuEQz39Bm dd6akzZ//URNQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rrtfs-000xdz-RZ; Wed, 03 Apr 2024 07:00:40 +0100 Date: Wed, 03 Apr 2024 07:00:40 +0100 Message-ID: <86frw3t27r.wl-maz@kernel.org> From: Marc Zyngier To: Tangnianyao Cc: , , , , Subject: Re: [PATCH] irqchip/gic-v3-its: Don't need VSYNC if VMAPP with {V, Alloc}=={0, x} In-Reply-To: References: <20240402114147.3788881-1-tangnianyao@huawei.com> <86jzlgt014.wl-maz@kernel.org> <8532b19b-361e-2234-92db-83f4d56bae19@huawei.com> <86il0zubh1.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tangnianyao@huawei.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, guoyang2@huawei.com, wangwudi@hisilicon.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 03 Apr 2024 03:18:51 +0100, Tangnianyao wrote: > > > > On 4/2/2024 21:43, Marc Zyngier wrote: > > On Tue, 02 Apr 2024 14:32:40 +0100, > > Tangnianyao wrote: > >> > >> > >> Thank you for quick fix, it would be great to remove this VSYNC. ITS handling VSYNC unmap > >> vpeid may waste some time, trigger exception and needed to be > >> handled. > > Do you actually see an exception being delivered from this? > > > > In any case, feel free to respin the patch after having tested this > > diff, with the commit message fixed and a Fixes: tag attached to it. > > In our developing implemenation, ITS would report RAS when doing vsync > and reaching an invalid vpe table entry. It is reasonable to report RAS, right? If a RAS error is the only reporting method you have, then I suspect you don't have much of a choice (the pseudocode indicates an IMPDEF SError for VSYNC). Shame this wasn't caught earlier. > It just reports, and kernel can still run normally regardless of > this RAS message. That really depends on the policy behind RAS errors. Looking forward to your respinning of this patch. Thanks, M. -- Without deviation from the norm, progress is not possible.