From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE4FBC4332F for ; Wed, 28 Dec 2022 10:38:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232858AbiL1KiJ (ORCPT ); Wed, 28 Dec 2022 05:38:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232969AbiL1KiD (ORCPT ); Wed, 28 Dec 2022 05:38:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 795B41142; Wed, 28 Dec 2022 02:38:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 162136145B; Wed, 28 Dec 2022 10:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64E2EC433D2; Wed, 28 Dec 2022 10:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672223881; bh=ukEG+mxZCrVb4P02TVQEmq/oWyPRaEZkv/wBhkH7xQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YX28XbkSNNpCc0eciXPnPrUXZ5EQPyu+SvGYdTZyutPY8UPeYh5OYGDag7K2X5wS8 0Vs9SBZEXgeK3Lfx6c55LW6he+lW6N6Gq/KiaPbi9/ipM3EXg7bxA8tlz1yopR7xJ7 gINUQKgzgyelxEqvhZdGarNSQP9FggZA/h15FodYRvnonEDLY538xrA4hmWdceNt5m mGraz180DGYFnP1uMnkdVJbLJbgfDxoMXL/wV9rPyXucwl05pzQho+rBpNsR/lNSVU dW78Ez/Rhe1AgXwjDC+B3FwIGgq04yk6fNQcAYY5CUAWt0MSDLXx/lDWsDn/6t4EnD zH29c1DpjuUJA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pATot-00FX6g-2A; Wed, 28 Dec 2022 10:37:59 +0000 Date: Wed, 28 Dec 2022 10:37:58 +0000 Message-ID: <86fsczbypl.wl-maz@kernel.org> From: Marc Zyngier To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Guenter Roeck , mpe@ellerman.id.au, christophe.leroy@csgroup.eu, windhl@126.com, Julia.Lawall@inria.fr, joel@jms.id.au, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH AUTOSEL 4.14 3/4] powerpc/msi: Fix deassociation of MSI descriptors In-Reply-To: <20221227203611.1214818-3-sashal@kernel.org> References: <20221227203611.1214818-1-sashal@kernel.org> <20221227203611.1214818-3-sashal@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashal@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux@roeck-us.net, mpe@ellerman.id.au, christophe.leroy@csgroup.eu, windhl@126.com, Julia.Lawall@inria.fr, joel@jms.id.au, linuxppc-dev@lists.ozlabs.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Dec 2022 20:36:08 +0000, Sasha Levin wrote: > > From: Marc Zyngier > > [ Upstream commit 4545c6a3d6ba71747eaa984c338ddd745e56e23f ] > > Since 2f2940d16823 ("genirq/msi: Remove filter from > msi_free_descs_free_range()"), the core MSI code relies on the > msi_desc->irq field to have been cleared before the descriptor > can be freed, as it indicates that there is no association with > a device anymore. > > The irq domain code provides this guarantee, and so does s390, > which is one of the two architectures not using irq domains for > MSIs. > > Powerpc, however, is missing this particular requirements, > leading in a splat and leaked MSI descriptors. > > Adding the now required irq reset to the handful of powerpc backends > that implement MSIs fixes that particular problem. > > Reported-by: Guenter Roeck > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/70dab88e-6119-0c12-7c6a-61bcbe239f66@roeck-us.net > Signed-off-by: Sasha Levin > --- > arch/powerpc/platforms/4xx/hsta_msi.c | 1 + > arch/powerpc/platforms/cell/axon_msi.c | 1 + > arch/powerpc/platforms/pasemi/msi.c | 1 + > arch/powerpc/sysdev/fsl_msi.c | 1 + > arch/powerpc/sysdev/mpic_u3msi.c | 1 + > 5 files changed, 5 insertions(+) Please drop this patch from all stable branches. It isn't needed before 6.2, and doesn't fix anything on its own as nobody uses this structure after this point. M. -- Without deviation from the norm, progress is not possible.