From: Marc Zyngier <maz@kernel.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Usama Arif <usama.arif@bytedance.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
linux-doc@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux@armlinux.org.uk,
yezengruan@huawei.com, catalin.marinas@arm.com, will@kernel.org,
steven.price@arm.com, mark.rutland@arm.com,
fam.zheng@bytedance.com, liangma@liangbit.com,
punit.agrawal@bytedance.com
Subject: Re: [PATCH] kvm/arm: Fix pvtime documentation
Date: Thu, 03 Nov 2022 15:42:51 +0000 [thread overview]
Message-ID: <86fsf0qc1w.wl-maz@kernel.org> (raw)
In-Reply-To: <24d81fe9-7cd1-71eb-8c35-0739f638b3df@gmail.com>
On Thu, 03 Nov 2022 13:55:29 +0000,
Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 11/3/22 20:12, Usama Arif wrote:
> > This includes table format and using reST labels for
> > cross-referencing to vcpu.rst.
> >
> > Suggested-by: Bagas Sanjaya <bagasdotme@gmail.com>
> > Signed-off-by: Usama Arif <usama.arif@bytedance.com>
>
> This is not what people normally do when given suggestion diff like
> what I sent before [1]. Instead, they just apply and squash the
> suggestion (while also applying requested changes from reviewers).
No, this is the correct course of action. There isn't any point in
having an *unrelated* change in a separate series. This is a
standalone change, posted as a standalone patch.
> Please reroll your series [2] with suggestion applied.
Or not.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2022-11-03 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 13:12 [PATCH] kvm/arm: Fix pvtime documentation Usama Arif
2022-11-03 13:45 ` Steven Price
2022-11-03 13:55 ` Bagas Sanjaya
2022-11-03 15:42 ` Marc Zyngier [this message]
2022-11-04 1:48 ` Bagas Sanjaya
2022-11-04 11:06 ` Marc Zyngier
2022-11-04 12:19 ` Bagas Sanjaya
2022-11-03 15:47 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86fsf0qc1w.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=fam.zheng@bytedance.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=liangma@liangbit.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=punit.agrawal@bytedance.com \
--cc=steven.price@arm.com \
--cc=usama.arif@bytedance.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yezengruan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox