From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34EC2C4332F for ; Thu, 3 Nov 2022 15:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232253AbiKCPnM (ORCPT ); Thu, 3 Nov 2022 11:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbiKCPnH (ORCPT ); Thu, 3 Nov 2022 11:43:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C256B1B1DA; Thu, 3 Nov 2022 08:42:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 383A861F34; Thu, 3 Nov 2022 15:42:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A648C433D6; Thu, 3 Nov 2022 15:42:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667490174; bh=PmqtbmT9mQWma23ymagJ11tWufGstamjMkYv5eb/5qo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=P02zYSj2EXx8UFjhs0W38mcmH7PPhDxFrPAs3DIwwhe6kVMB5ibwdAun3jGpCY3Y0 M08VVoWub2n2hyrhtGRR+mmykQmLuUjOx4UNjXm1UNFay342V8GGHmWoTpGWxiOaKH u+Nb3RWExGgZHx0Tie5GDON9iPIaNrOz4o0S9sKqUM9AYwtKKEWBOLvdCL2C47/yYX 1ooW7JvbX5/t0zVJf1DccEtvFvn2k/ObkEawkO86X17x3V2vSX8ofZ2bXJYj+hwaqZ HLWQU546DfPaovhrx6xD/ATmcTYzFxi1OLvcUMh6DrdUDLb+OUf+r9/r10eCBExuhV v6tNjRSjvqybA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oqcMm-003Xt1-3n; Thu, 03 Nov 2022 15:42:52 +0000 Date: Thu, 03 Nov 2022 15:42:51 +0000 Message-ID: <86fsf0qc1w.wl-maz@kernel.org> From: Marc Zyngier To: Bagas Sanjaya Cc: Usama Arif , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org, linux@armlinux.org.uk, yezengruan@huawei.com, catalin.marinas@arm.com, will@kernel.org, steven.price@arm.com, mark.rutland@arm.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com Subject: Re: [PATCH] kvm/arm: Fix pvtime documentation In-Reply-To: <24d81fe9-7cd1-71eb-8c35-0739f638b3df@gmail.com> References: <20221103131210.3603385-1-usama.arif@bytedance.com> <24d81fe9-7cd1-71eb-8c35-0739f638b3df@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: bagasdotme@gmail.com, usama.arif@bytedance.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org, linux@armlinux.org.uk, yezengruan@huawei.com, catalin.marinas@arm.com, will@kernel.org, steven.price@arm.com, mark.rutland@arm.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 03 Nov 2022 13:55:29 +0000, Bagas Sanjaya wrote: > > On 11/3/22 20:12, Usama Arif wrote: > > This includes table format and using reST labels for > > cross-referencing to vcpu.rst. > > > > Suggested-by: Bagas Sanjaya > > Signed-off-by: Usama Arif > > This is not what people normally do when given suggestion diff like > what I sent before [1]. Instead, they just apply and squash the > suggestion (while also applying requested changes from reviewers). No, this is the correct course of action. There isn't any point in having an *unrelated* change in a separate series. This is a standalone change, posted as a standalone patch. > Please reroll your series [2] with suggestion applied. Or not. M. -- Without deviation from the norm, progress is not possible.