Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()

Paolo Bonzini
2024-02-23T15:32:11Z

On Fri, Feb 16, 2024 at 5:00 PM Oliver Upton <oliver.upton@linux.dev> wrote:
>
> The general expectation with debugfs is that any initialization failure
> is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows
> implementations to return an error and kvm_create_vm_debugfs() allows
> that to fail VM creation.
>
> Change to a void return to discourage architectures from making debugfs
> failures fatal for the VM. Seems like everyone already had the right
> idea, as all implementations already return 0 unconditionally.
>
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Feel free to place it in kvm-arm.

Paolo