Re: [PATCH] KVM: Get rid of return value from kvm_arch_create_vm_debugfs()

Marc Zyngier
2024-02-16T17:13:14Z

On Fri, 16 Feb 2024 15:59:41 +0000,
Oliver Upton <oliver.upton@linux.dev> wrote:
>
> The general expectation with debugfs is that any initialization failure
> is nonfatal. Nevertheless, kvm_arch_create_vm_debugfs() allows
> implementations to return an error and kvm_create_vm_debugfs() allows
> that to fail VM creation.
>
> Change to a void return to discourage architectures from making debugfs
> failures fatal for the VM. Seems like everyone already had the right
> idea, as all implementations already return 0 unconditionally.
>
> Signed-off-by: Oliver Upton <oliver.upton@linux.dev>

Acked-by: Marc Zyngier <maz@kernel.org>

M.

--
Without deviation from the norm, progress is not possible.