From: Marc Zyngier <marc.zyngier@arm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Paul Mackerras" <paulus@samba.org>,
kernel-hardening@lists.openwall.com,
"Kees Cook" <keescook@chromium.org>,
"Christian Borntraeger" <borntraeger@redhat.com>,
"Christoffer Dall" <cdall@linaro.org>,
"Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch
Date: Thu, 26 Oct 2017 15:34:38 +0100 [thread overview]
Message-ID: <86h8umasg1.fsf@arm.com> (raw)
In-Reply-To: <20171026134547.23664-2-pbonzini@redhat.com> (Paolo Bonzini's message of "Thu, 26 Oct 2017 15:45:46 +0200")
On Thu, Oct 26 2017 at 3:45:46 pm BST, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region
> taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86)
> or KVM_GET/SET_ONE_REG (ARM/s390). Without whitelisting the area,
> KVM is completely broken on those architectures with usercopy hardening
> enabled.
>
> For now, allow writing to the entire struct on all architectures.
> The KVM tree will not refine this to an architecture-specific
> subset of struct kvm_vcpu_arch.
>
> Cc: kernel-hardening@lists.openwall.com
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Christian Borntraeger <borntraeger@redhat.com>
> Cc: Christoffer Dall <cdall@linaro.org>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2017-10-26 14:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 13:45 [PATCH v2 0/2] KVM: fixes for the kernel-hardening tree Paolo Bonzini
2017-10-26 13:45 ` [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch Paolo Bonzini
2017-10-26 14:13 ` Cornelia Huck
2017-10-26 14:21 ` Christoffer Dall
2017-10-26 14:34 ` Marc Zyngier [this message]
2017-10-26 14:51 ` Christian Borntraeger
2017-10-30 23:28 ` [kernel-hardening] " Eric Biggers
2017-10-30 23:51 ` Kees Cook
2017-10-26 13:45 ` [PATCH 2/2] kvm: x86: fix KVM_XEN_HVM_CONFIG ioctl Paolo Bonzini
2017-10-26 13:48 ` Kees Cook
2017-11-30 20:40 ` Kees Cook
2017-12-01 8:29 ` Paolo Bonzini
2017-10-27 5:25 ` [PATCH v2 0/2] KVM: fixes for the kernel-hardening tree Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h8umasg1.fsf@arm.com \
--to=marc.zyngier@arm.com \
--cc=borntraeger@de.ibm.com \
--cc=borntraeger@redhat.com \
--cc=cdall@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=cohuck@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox