From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2898E2F5E; Tue, 9 Sep 2025 11:21:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416905; cv=none; b=A9AfEqrXRfMV2tXN1kO4CDkJSaBC94QXaKYp8cdgBs0KUbwXkJsn8JZCpbBeUVk6PcI4X5XazgpMuDzwU/JU3QyZ0rbqzOdYpjsHP0wJcJZEw+YGTLIXYj8F4Lsxi6p9o9yj99d87mlB7I8ykn/sZjNmRpCsi9sgpnTMVeS6e1U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757416905; c=relaxed/simple; bh=WGVbI7np7xhsccUcZ2mq8FQt+c4KbxvQmTFbkCyFxsU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ZN4hKr87Vf52TExEKG7mG335twiUQTQHwISXzN0jJ2aL6rB/o3uJgqWjUezXgJILUYgH6LpSI0eHUd6EbL5CD4n+UsXMKX12W3msz80ivhfU0+tZm9U+N8AIkHB4GV5irBEDoGKMKwUTCtr20kuocjG2qFUAxWsTsEUXgWZIvco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=spnzCgdC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="spnzCgdC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F9EDC4CEF4; Tue, 9 Sep 2025 11:21:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757416904; bh=WGVbI7np7xhsccUcZ2mq8FQt+c4KbxvQmTFbkCyFxsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=spnzCgdCWnXyXf6fPVwUl5AFWzK/6O6noknQOaiNR743uSzQ4li/wAT8TINQ8Zb8h 2HmJNNYdO8hH+26KkHtfTZ8jgJ65/zTew228hvgi8OSovHBKFDJPs+7sHTClAUFRhM z6vXpNscUiyQYg3nbezYFN1d65jc4mHeYM7SqA5wKSSGZFRxTw9CQsiZIfCQ/eH+Tv c14Mtwbke+oIyH6nT4sdxMXMh/KKCzRYN7nDwU2nHk/5mL+7ORoShsLuBIYW74ZLWU xpJlKzqNR4wURL4jPeSwKM3AJX50gJD2ZOCG/UdgoMb7YQ/TIO0sor3B43Gin6CiOX UoTjIseNn4tgg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1uvwPu-00000004ewP-13PZ; Tue, 09 Sep 2025 11:21:42 +0000 Date: Tue, 09 Sep 2025 12:21:41 +0100 Message-ID: <86ikhrdg6y.wl-maz@kernel.org> From: Marc Zyngier To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, Mark Rutland , Will Deacon , "Rafael J. Wysocki" , Rob Herring , Saravana Kannan , Greg Kroah-Hartman , Sven Peter , Janne Grunau , Suzuki K Poulose , James Clark Subject: Re: [PATCH 14/25] genirq: Update request_percpu_nmi() to take an affinity In-Reply-To: <877by8vu0v.ffs@tglx> References: <20250908163127.2462948-1-maz@kernel.org> <20250908163127.2462948-15-maz@kernel.org> <877by8vu0v.ffs@tglx> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, mark.rutland@arm.com, will@kernel.org, rafael@kernel.org, robh@kernel.org, saravanak@google.com, gregkh@linuxfoundation.org, sven@kernel.org, j@jannau.net, suzuki.poulose@arm.com, james.clark@linaro.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 09 Sep 2025 10:45:36 +0100, Thomas Gleixner wrote: > > On Mon, Sep 08 2025 at 17:31, Marc Zyngier wrote: > > @@ -2564,13 +2566,14 @@ int request_percpu_nmi(unsigned int irq, irq_handler_t handler, > > !irq_supports_nmi(desc)) > > return -EINVAL; > > > > - /* The line cannot already be NMI */ > > - if (irq_is_nmi(desc)) > > + /* The line cannot be NMI already if the new request covers all CPUs */ > > + if (irq_is_nmi(desc) && > > + (!affinity || cpumask_equal(affinity, cpu_possible_mask))) > > return -EINVAL; > > This check looks odd. What makes sure that the affinities do not > overlap? The following patch in the series does, at the point of adding the new irqaction to the list. This is modelled after the current handling of shared interrupts. M. -- Without deviation from the norm, progress is not possible.