public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [patch 0/2] PCI/MSI: Avoid PCI level masking during normal operation if requested
Date: Tue, 09 Sep 2025 11:21:43 +0100	[thread overview]
Message-ID: <86jz28c4eg.wl-maz@kernel.org> (raw)
In-Reply-To: <20250903134437.863638669@linutronix.de>

On Wed, 03 Sep 2025 15:04:44 +0100,
Thomas Gleixner <tglx@linutronix.de> wrote:
> 
> This is a follow up to Marc's attempt on this:
> 
>      https://lore.kernel.org/lkml/20250517103011.2573288-1-maz@kernel.org
> 
> Now that the PCI/MSI side has irq_startup/shutdown() callbacks, which do
> the [un]masking at the PCI level, let the MSI parent domains which insist
> on being in charge of masking do so for normal operations.
> 
> That avoids going out to the PCI endpoint in the case that an interrupt has
> to be masked on arrival of an interrupt in software (lazy) disabled state.
> 
> That's achieved by overwriting the irq_[un]mask() callbacks in the irq/MSI
> library.
> 
> As a consequence the conditional mask/unmask logic in the regular
> irq_[un]mask() callbacks of the PCI/MSI domain is not longer required.

I took this for a quick ride on some of my least favourite machines,
and nothing caught fire.

FWIW:

Acked-by: Marc Zyngier <maz@kernel.org>
Tested-by: Marc Zyngier <maz@kernel.org>

Thanks for having re-spun it,

	M.

-- 
Without deviation from the norm, progress is not possible.

      parent reply	other threads:[~2025-09-09 10:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-17 10:30 [PATCH] irqchip/msi-lib: Honor the MSI_FLAG_PCI_MSI_MASK_PARENT flag Marc Zyngier
2025-05-17 19:59 ` Thomas Gleixner
2025-05-23  9:06   ` Marc Zyngier
2025-06-30  8:59     ` Thomas Gleixner
2025-09-03 14:04       ` [patch 0/2] PCI/MSI: Avoid PCI level masking during normal operation if requested Thomas Gleixner
2025-09-03 14:04         ` [patch 1/2] irqchip/msi-lib: Honor the MSI_FLAG_PCI_MSI_MASK_PARENT flag Thomas Gleixner
2025-09-09 12:47           ` [tip: irq/drivers] " tip-bot2 for Marc Zyngier
2025-12-20 19:31           ` [patch 1/2] " Luigi Rizzo
2025-12-21 11:55             ` Marc Zyngier
2025-12-21 12:41               ` Luigi Rizzo
2025-12-22 16:16                 ` Marc Zyngier
2026-01-08 21:32                   ` Thomas Gleixner
2026-01-08 21:55                     ` Luigi Rizzo
2026-01-09 12:20                       ` Thomas Gleixner
2026-01-09 13:00                         ` Luigi Rizzo
2026-01-09 17:01                           ` Thomas Gleixner
2025-09-03 14:04         ` [patch 2/2] PCI/MSI: Remove the conditional parent [un]mask logic Thomas Gleixner
2025-09-03 17:38           ` Bjorn Helgaas
2025-09-09 12:47           ` [tip: irq/drivers] " tip-bot2 for Thomas Gleixner
2025-09-09 10:21         ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jz28c4eg.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox