From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27A338F91; Mon, 13 Jan 2025 16:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736786994; cv=none; b=QYcQWr2JCclmJFgOt/gm0pxJcnVpIQBOh1HD4A1imjXIi1SqUmlTiAHKKZ9XVZwpHhsK9UTVlGm2u2t6Ys4DZU+W/rVAQjEidmyMFz01NM3HcU+R2aMsfR251sbFUvqSrnLs8+upMe702AzxuWO1wB5BzIbWGR5RmB8+a6Ipb8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736786994; c=relaxed/simple; bh=krodteQ9YYEeKdLpxISnJBtZdT55UGPVBi/zs6nCa/Y=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=pn9aFajFrNavjFeNMQ7z4Ug+2B6mtM0mFFhA4n1o3rxm1Edy/gcx5nSySJcH5hs+dBlR2hk6CnsvJo+9y2LsFJKc5Dks825AUMCithexmSDgMu8moqg1H2EXcjzq7ZwRCp8DVdR8yQWAyUwFNVTY4ohEuRle39fg9JdOrIwi3uc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jhSd41QX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jhSd41QX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BFAAC4CEE1; Mon, 13 Jan 2025 16:49:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736786994; bh=krodteQ9YYEeKdLpxISnJBtZdT55UGPVBi/zs6nCa/Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jhSd41QXu4NPMNaE/qYkDHUaJYo3IwT5C53zoZkL8DnuSw4hGJQ5ZYDzREGEEOdL7 GdbuXLk2etxvHkv1LRYazY25EaSlp7dsKzA/6JpxdQ8mpS6LG3TwiGexF5QklU1Z0I PkM6up5FmW7k7+8zQ5nfUpn64U14iK7PTTJRW2Z0D2CB/Icv708N9+u+gtfqfmiTMw ZnmHqH/bHbd6ALxU+nGFI1WQDZ9zwXATs61o8CmRBoyTUBRdKM5Ep3jdd5ax50xz7w /hcWBuuPcgwtfW2Euv0fnliPg4+1riDGal3wXzFp1fTNz+6gQf2GCHSPfIE3Qxhlwa yNEJ1rNTOiYrw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tXNdO-00BhXU-G7; Mon, 13 Jan 2025 16:49:50 +0000 Date: Mon, 13 Jan 2025 16:49:49 +0000 Message-ID: <86jzaywtea.wl-maz@kernel.org> From: Marc Zyngier To: James Clark Cc: Mark Brown , kvmarm@lists.linux.dev, oliver.upton@linux.dev, suzuki.poulose@arm.com, coresight@lists.linaro.org, James Clark , Joey Gouly , Zenghui Yu , Catalin Marinas , Will Deacon , Mike Leach , Alexander Shishkin , Mark Rutland , Anshuman Khandual , "Rob Herring (Arm)" , Shiqi Liu , James Morse , Fuad Tabba , Raghavendra Rao Ananta , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 04/10] arm64/sysreg: Add a comment that the sysreg file should be sorted In-Reply-To: <760969b6-18b7-42ac-9524-2f1f845b3703@linaro.org> References: <20250107113252.260631-1-james.clark@linaro.org> <20250107113252.260631-5-james.clark@linaro.org> <87frloqjso.wl-maz@kernel.org> <760969b6-18b7-42ac-9524-2f1f845b3703@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: james.clark@linaro.org, broonie@kernel.org, kvmarm@lists.linux.dev, oliver.upton@linux.dev, suzuki.poulose@arm.com, coresight@lists.linaro.org, james.clark@arm.com, joey.gouly@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, mike.leach@linaro.org, alexander.shishkin@linux.intel.com, mark.rutland@arm.com, anshuman.khandual@arm.com, robh@kernel.org, shiqiliu@hust.edu.cn, james.morse@arm.com, tabba@google.com, rananta@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 13 Jan 2025 15:43:39 +0000, James Clark wrote: > > > > On 12/01/2025 12:49 pm, Marc Zyngier wrote: > > On Tue, 07 Jan 2025 11:32:41 +0000, > > James Clark wrote: > >> > >> From: James Clark > >> > >> There are a few entries particularly at the end of the file that aren't > >> in order. To avoid confusion, add a comment that might help new entries > >> to be added in the right place. > >> > >> Reviewed-by: Mark Brown > >> Signed-off-by: James Clark > >> Signed-off-by: James Clark > >> --- > >> arch/arm64/tools/sysreg | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg > >> index b081b54d6d22..4ba167089e2a 100644 > >> --- a/arch/arm64/tools/sysreg > >> +++ b/arch/arm64/tools/sysreg > >> @@ -48,6 +48,8 @@ > >> # feature that introduces them (eg, FEAT_LS64_ACCDATA introduces enumeration > >> # item ACCDATA) though it may be more taseful to do something else. > >> +# Please try to keep entries in this file sorted by sysreg > >> encoding. > >> + > >> Sysreg OSDTRRX_EL1 2 0 0 0 2 > >> Res0 63:32 > >> Field 31:0 DTRRX > > > > "Do as I say, don't do as I do". > > > > I don't think this makes any sense if we don't actually sort the file > > the first place. > > > > M. > > > > I think it's ok if it avoids review comments that new entries should > be sorted. Or maybe we do the opposite and the comment should say this > file is allowed to be unsorted... The better option would be to add the comment *and* sort the file. Leading by example has some value, it seems. M. -- Without deviation from the norm, progress is not possible.