From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C254CCDB483 for ; Thu, 19 Oct 2023 11:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345402AbjJSLja (ORCPT ); Thu, 19 Oct 2023 07:39:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235219AbjJSLj1 (ORCPT ); Thu, 19 Oct 2023 07:39:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 488AC18A for ; Thu, 19 Oct 2023 04:39:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF650C433C7; Thu, 19 Oct 2023 11:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697715564; bh=6+e6tFBhwXttTI2OnODBoBY84he1JXmNi2O8ceFHcY0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cGUkEUnkDwmjLpWSwji7kRrKtBa9/hEFyX1iZYjdhNx6Mv3SyPW5vmc99ct4ClHXl Fuba2gKB5+qguHr7lh0RI7x1+WZKB6Gf1TCkOMWn94Ifjs9d/uylja4ccrJXyF6gTY qCu5pS1LTACCS+mGdaj+KnJ54lqmY2kXfQj6oRwdyIoLcTAEeev2K8xqr5KYNEk80W ZuFHhJuIrIbYJ1Tcf1lNkwpHxjiM2gzJq7oZlQgn9HTu7eTICP5wr8uC6ZYgp8HlQX Mqg9fOlC/GP0m3p9WGXQuDk8x+lt/NPEY4GttIrCGOPYHXeYjC3biUr7tcPjWOMEVx pe/fWT2I/Ex7Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qtRN4-005jF6-61; Thu, 19 Oct 2023 12:39:22 +0100 Date: Thu, 19 Oct 2023 12:39:21 +0100 Message-ID: <86jzrin8nq.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: Catalin Marinas , Will Deacon , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Jing Zhang , Eric Auger , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v4 2/3] arm64: Add missing _EL2 encodings In-Reply-To: <20231016111743.30331-3-miguel.luis@oracle.com> References: <20231016111743.30331-1-miguel.luis@oracle.com> <20231016111743.30331-3-miguel.luis@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, jingzhangos@google.com, eric.auger@redhat.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Oct 2023 12:17:41 +0100, Miguel Luis wrote: > > Some _EL2 encodings are missing. Add them. > > Signed-off-by: Miguel Luis > --- > arch/arm64/include/asm/sysreg.h | 39 +++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index ba5db50effec..8653fb67a339 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h [...] > +#define SYS_SDER32_EL2 sys_reg(3, 4, 1, 3, 1) [...] > +#define SYS_VSTTBR_EL2 sys_reg(3, 4, 2, 6, 0) > +#define SYS_VSTCR_EL2 sys_reg(3, 4, 2, 6, 2) [...] > +#define SYS_CNTHVS_TVAL_EL2 sys_reg(3, 4, 14, 4, 0) > +#define SYS_CNTHVS_CTL_EL2 sys_reg(3, 4, 14, 4, 1) > +#define SYS_CNTHVS_CVAL_EL2 sys_reg(3, 4, 14, 4, 2) > +#define SYS_CNTHPS_TVAL_EL2 sys_reg(3, 4, 14, 5, 0) > +#define SYS_CNTHPS_CTL_EL2 sys_reg(3, 4, 14, 5, 1) > +#define SYS_CNTHPS_CVAL_EL2 sys_reg(3, 4, 14, 5, 2) While the secure definitions seem correct, what is the rationale behind their presence here? They cannot be trapped from non-secure, and the pseudocode is pretty explicit: if !IsCurrentSecurityState(SS_Secure) then UNDEFINED; Given that, they cannot be trapped, handled or accessed from a KVM guest, as Linux on arm64 *always* runs non-secure. M. -- Without deviation from the norm, progress is not possible.