Re: [PATCH 09/12] irqchip: cirrus: Add driver for Cirrus Logic CS48L31/32/33 codecs

Mark Brown
2022-11-10T13:01:43Z

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

On Thu, Nov 10, 2022 at 11:22:26AM +0000, Richard Fitzgerald wrote:
> On 10/11/2022 08:02, Marc Zyngier wrote:

> > belongs IMO to the MFD code.

> We did once put interrupt support in MFD for an older product line but
> the MFD maintainer doesn't like the MFD being a dumping-ground for
> random other functionality that have their own subsystems.

There's bits of this like logging the top level error interrupts that
seem like they clearly fit in the driver for the top level chip (SYSCLK
possibly in the audio driver, dunno if it gets used by other functions),
they're users of the interrupt controller rather than part of the
interrupt controller.

> > It is also a direct copy of the existing
> > irq-madera.c code, duplicated for no obvious reason.

> It's not a duplicate. The register map of this device is different
> (different addressing, 32-bit registers not 16-bit)

Isn't that just a data difference which could be parameterised?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]